Page MenuHomePhabricator
Differential D8771

test: Reduce unneeded whitelist permissions in tests
ClosedPublic
Actions

Authored by PiRK on Jan 4 2021, 09:43.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC3f7a57ff8c5e: test: Reduce unneeded whitelist permissions in tests
Summary

It makes the tests confusing and fragile when overwriting default command line values that are not needed to be overwritten.

This is a backport of Core PR18209

Test Plan

ninja && test/functional/test_runner.py feature_* p2p_invalid_block rpc_fundrawtransaction wallet_*

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Jan 4 2021, 09:43
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 4 2021, 09:43
PiRK requested review of this revision.Jan 4 2021, 09:43
teamcity edited the summary of this revision. (Show Details)Jan 4 2021, 09:43
Harbormaster completed remote builds in B14543: Diff 26597.Jan 4 2021, 09:59
Fabien requested changes to this revision.Jan 4 2021, 14:04
Fabien added a subscriber: Fabien.

This is missing all the abc-* tests

This revision now requires changes to proceed.Jan 4 2021, 14:04
PiRK updated this revision to Diff 26606.Jan 4 2021, 14:26

Apply this change also to abc* tests

Additional test plan:
ninja && test/functional/test_runner.py abc*
grep whitelist test/functional/abc*

Harbormaster completed remote builds in B14551: Diff 26606.Jan 4 2021, 14:45
Fabien requested changes to this revision.Jan 4 2021, 19:29
Fabien added inline comments.
test/functional/abc_rpc_excessiveblock.py
28 ↗(On Diff #26606)

This is probably not needed at all, I don't think there is any ban behavior in this test

This revision now requires changes to proceed.Jan 4 2021, 19:29
PiRK updated this revision to Diff 26619.Jan 5 2021, 07:11

remove whitelist parameter from abc_rpc_excessiveblock

Harbormaster completed remote builds in B14560: Diff 26619.Jan 5 2021, 07:25
Fabien accepted this revision.Jan 5 2021, 09:24
This revision is now accepted and ready to land.Jan 5 2021, 09:24
Closed by commit rABC3f7a57ff8c5e: test: Reduce unneeded whitelist permissions in tests (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhyJan 5 2021, 09:49
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC3f7a57ff8c5e: test: Reduce unneeded whitelist permissions in tests.

Revision Contents
Changeset List

Diff 26624

View Options

test/functional/abc-invalid-chains.py

Loading...
View Options

test/functional/abc-magnetic-anomaly-mining.py

Loading...
View Options

test/functional/abc-mempool-coherence-on-activations.py

Loading...
View Options

test/functional/abc-replay-protection.py

Loading...
View Options

test/functional/abc-segwit-recovery.py

Loading...
View Options

test/functional/abc-transaction-ordering.py

Loading...
View Options

test/functional/abc_p2p_compactblocks.py

Loading...
View Options

test/functional/abc_p2p_fullblocktest.py

Loading...
View Options

test/functional/abc_rpc_excessiveblock.py

Loading...
View Options

test/functional/feature_cltv.py

Loading...
View Options

test/functional/feature_csv_activation.py

Loading...
View Options

test/functional/feature_dersig.py

Loading...
View Options

test/functional/feature_maxuploadtarget.py

Loading...
View Options

test/functional/p2p_invalid_block.py

Loading...
View Options

test/functional/rpc_fundrawtransaction.py

Loading...
View Options

test/functional/wallet_address_types.py

Loading...
View Options

test/functional/wallet_avoidreuse.py

Loading...
View Options

test/functional/wallet_backup.py

Loading...