Page MenuHomePhabricator

test: Reduce unneeded whitelist permissions in tests
ClosedPublic

Authored by PiRK on Jan 4 2021, 09:43.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC3f7a57ff8c5e: test: Reduce unneeded whitelist permissions in tests
Summary

It makes the tests confusing and fragile when overwriting default command line values that are not needed to be overwritten.

This is a backport of Core PR18209

Test Plan

ninja && test/functional/test_runner.py feature_* p2p_invalid_block rpc_fundrawtransaction wallet_*

Diff Detail

Event Timeline

PiRK requested review of this revision.Jan 4 2021, 09:43
Fabien requested changes to this revision.Jan 4 2021, 14:04
Fabien added a subscriber: Fabien.

This is missing all the abc-* tests

This revision now requires changes to proceed.Jan 4 2021, 14:04

Apply this change also to abc* tests

Additional test plan:
ninja && test/functional/test_runner.py abc*
grep whitelist test/functional/abc*

Fabien requested changes to this revision.Jan 4 2021, 19:29
Fabien added inline comments.
test/functional/abc_rpc_excessiveblock.py
28

This is probably not needed at all, I don't think there is any ban behavior in this test

This revision now requires changes to proceed.Jan 4 2021, 19:29

remove whitelist parameter from abc_rpc_excessiveblock

This revision is now accepted and ready to land.Jan 5 2021, 09:24