Differential D8781

[net_processing] Change PeerLogicValidation to hold a connman reference
ClosedPublic
Actions

Authored by Fabien on Jan 5 2021, 10:08.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCfd797bb03376: [net_processing] Change PeerLogicValidation to hold a connman reference

Summary

`
Hold a reference to connman rather than a pointer because:

- PeerLogicValidation can't run without a connman
- The pointer never gets reseated

The alternative is to always assert that the pointer is non-null before
dereferencing.

Change the name from connman to m_connman at the same time to conform
with current style guidelines.

Partial backport (1/2) of core PR19704:
https://github.com/bitcoin/bitcoin/pull/19704/commits/c556770b5ef4306f10e980daff772bee87daaa30

Depends on D8777.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jan 5 2021, 10:08

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 5 2021, 10:08

Fabien requested review of this revision.Jan 5 2021, 10:08

teamcity edited the summary of this revision. (Show Details)Jan 5 2021, 10:08

Fabien added a child revision: D8782: [net_processing] Move ProcessMessage to PeerLogicValidation.Jan 5 2021, 10:17

Harbormaster completed remote builds in B14562: Diff 26625.Jan 5 2021, 10:30

PiRK accepted this revision.Jan 5 2021, 16:19

This revision is now accepted and ready to land.Jan 5 2021, 16:19

Closed by commit rABCfd797bb03376: [net_processing] Change PeerLogicValidation to hold a connman reference (authored by John Newbery <john@johnnewbery.com>, committed by Fabien). · Explain WhyJan 6 2021, 10:42

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCfd797bb03376: [net_processing] Change PeerLogicValidation to hold a connman reference.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

test/

processor_tests.cpp

4 lines

2 lines

net_processing.h

4 lines

net_processing.cpp

92 lines

test/

denialofservice_tests.cpp

8 lines

util/

setup_common.cpp

2 lines

Diff 26670

src/avalanche/test/processor_tests.cpp

Loading...

src/init.cpp

Loading...

src/net_processing.h

Loading...

src/net_processing.cpp

Loading...

src/test/denialofservice_tests.cpp

Loading...

src/test/util/setup_common.cpp

Loading...