Page MenuHomePhabricator

Moved Misbehaving() overload to header file
AbandonedPublic

Authored by jasonbcox on Fri, Sep 27, 17:22.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Summary

This makes the code cleaner by allowing the Misbehaving() overload to be used outside of net_processing.cpp.

Depends on D4150

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
misbehaving
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 7615
Build 13270: Bitcoin ABC Teamcity Staging
Build 13269: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Fri, Sep 27, 17:22

This seems to me to be gratuitously moving away from core for no good reason. What's the reason?

src/net_processing.h
131

I'm not sure what this combination of qualifier does.

jasonbcox abandoned this revision.Fri, Sep 27, 22:16

I think you're right.