Page MenuHomePhabricator

net: Avoid redundant and confusing FAILED log
ClosedPublic

Authored by Fabien on Jan 4 2021, 16:29.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC25d0b1e38a93: net: Avoid redundant and confusing FAILED log
Summary
Remove a redundant and confusing "FAILED" log message and gets rid of
the unused return type in ProcessMessage

Backport of core PR19293.

Depends on D4150.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested review of this revision.Jan 4 2021, 16:29

Tail of the build log:

../../src/wallet/test/psbt_wallet_tests.cpp(16): Entering test suite "psbt_wallet_tests"
../../src/wallet/test/psbt_wallet_tests.cpp(18): Entering test case "psbt_updater_test"
Segmentation fault (core dumped)
[378/434] Running utility command for check-bitcoin-blockencodings_tests
[379/434] bitcoin: testing blockfilter_index_tests
[380/434] bitcoin: testing script_commitment_tests
[381/434] Running utility command for check-bitcoin-blockfilter_index_tests
[382/434] bitcoin: testing merkleblock_tests
[383/434] bitcoin: testing bip32_tests
[384/434] bitcoin: testing sighashtype_tests
[385/434] Running utility command for check-bitcoin-script_commitment_tests
[386/434] Running utility command for check-bitcoin-merkleblock_tests
[387/434] bitcoin: testing finalization_tests
[388/434] Running utility command for check-bitcoin-bip32_tests
[389/434] Running utility command for check-bitcoin-sighashtype_tests
[390/434] Running utility command for check-bitcoin-finalization_tests
[391/434] bitcoin: testing settings_tests
[392/434] Running utility command for check-bitcoin-settings_tests
[393/434] bitcoin: testing timedata_tests
[394/434] bitcoin: testing streams_tests
[395/434] bitcoin: testing uint256_tests
[396/434] Running utility command for check-bitcoin-timedata_tests
[397/434] Running utility command for check-bitcoin-streams_tests
[398/434] bitcoin: testing undo_tests
[399/434] Running utility command for check-bitcoin-uint256_tests
[400/434] Running utility command for check-bitcoin-undo_tests
[401/434] bitcoin: testing coins_tests
[402/434] bitcoin: testing walletdb_tests
[403/434] Running utility command for check-bitcoin-coins_tests
[404/434] bitcoin: testing util_threadnames_tests
[405/434] bitcoin: testing serialize_tests
[406/434] bitcoin: testing getarg_tests
[407/434] bitcoin: testing radix_tests
[408/434] bitcoin: testing txvalidationcache_tests
[409/434] bitcoin: testing crypto_tests
[410/434] Running utility command for check-bitcoin-walletdb_tests
[411/434] Running utility command for check-bitcoin-getarg_tests
[412/434] Running utility command for check-bitcoin-radix_tests
[413/434] bitcoin: testing validationinterface_tests
[414/434] bitcoin: testing schnorr_tests
[415/434] bitcoin: testing validation_chainstatemanager_tests
[416/434] Running utility command for check-bitcoin-crypto_tests
[417/434] Running utility command for check-bitcoin-txvalidationcache_tests
[418/434] Running utility command for check-bitcoin-serialize_tests
[419/434] Running utility command for check-bitcoin-util_threadnames_tests
[420/434] Running utility command for check-bitcoin-validationinterface_tests
[421/434] Running utility command for check-bitcoin-validation_chainstatemanager_tests
[422/434] Running utility command for check-bitcoin-schnorr_tests
[423/434] bitcoin: testing script_tests
[424/434] Running utility command for check-bitcoin-script_tests
[425/434] bitcoin: testing skiplist_tests
[426/434] Running utility command for check-bitcoin-skiplist_tests
[427/434] bitcoin: testing util_tests
[428/434] bitcoin: testing coinselector_tests
[429/434] Running utility command for check-bitcoin-util_tests
[430/434] Running utility command for check-bitcoin-coinselector_tests
[431/434] bitcoin: testing op_reversebytes_tests
[432/434] Running utility command for check-bitcoin-op_reversebytes_tests
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang failed with exit code 1
majcosta requested changes to this revision.Jan 4 2021, 17:28
majcosta added a subscriber: majcosta.

hm Segfault in build-clang

This revision now requires changes to proceed.Jan 4 2021, 17:28
Fabien requested review of this revision.Jan 5 2021, 08:59

This is the first time I see this error. Unfortunately I was unable to reproduce it, (I ran it hundred of times) and it is very likely unrelated to this diff.

majcosta added inline comments.
src/net_processing.cpp
4366 ↗(On Diff #26622)

remove pl0x

This revision is now accepted and ready to land.Jan 5 2021, 22:35