Page MenuHomePhabricator
Differential D8838

[cashtab] Upgrade webpack modules
ClosedPublic
Actions

Authored by deadalnix on Jan 7 2021, 18:56.

Details

Reviewers
bytesofman
Fabien
Group Reviewers
Restricted Project
Commits
rABC0dddb517c3f8: [cashtab] Upgrade webpack modules
Summary

As per title

Test Plan
npm run start

Check the app works.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Jan 7 2021, 18:56
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 7 2021, 18:56
deadalnix requested review of this revision.Jan 7 2021, 18:56
Harbormaster completed remote builds in B14648: Diff 26759.Jan 7 2021, 18:56
bytesofman requested changes to this revision.Jan 7 2021, 19:44
bytesofman added a subscriber: bytesofman.

I'm able to get npm install to work here with node v15.3.0 or v15.4.0 and npm v7.0.15 (but package-lock.json is different)

npm v7.3.0 runs into dependency issue without --legacy-peer-deps

What version of node and npm did you use for this diff?

Could you please run

cd cashtab/web
rm -rf node_modules
rm package-lock-json
npm i

and submit?

This revision now requires changes to proceed.Jan 7 2021, 19:44
deadalnix added a comment.Jan 8 2021, 13:43
In D8838#202946, @josephroyking wrote:

I'm able to get npm install to work here with node v15.3.0 or v15.4.0 and npm v7.0.15 (but package-lock.json is different)

npm v7.3.0 runs into dependency issue without --legacy-peer-deps

What version of node and npm did you use for this diff?

Could you please run

cd cashtab/web
rm -rf node_modules
rm package-lock-json
npm i

and submit?

Doing this kind of crap is EXACTLY what CI is for. Why are you doing it?

deadalnix updated this revision to Diff 26791.Jan 8 2021, 13:43

Updated package-lock and rebase

bytesofman requested changes to this revision.Jan 8 2021, 13:54

npm i needs to be run to update package-lock.json after this rebase as there are additional npm modules.

As you point out, this could be a CI change; enforce npm i before any arc diff, or even npm run build to make sure it builds.

This revision now requires changes to proceed.Jan 8 2021, 13:54
bytesofman accepted this revision.Jan 8 2021, 13:57

Never mind, I just ran the start command from the wrong folder. This is good to go.

This revision is now accepted and ready to land.Jan 8 2021, 13:57
Harbormaster completed remote builds in B14665: Diff 26791.Jan 8 2021, 13:57
deadalnix requested review of this revision.Jan 8 2021, 14:00
This comment was removed by deadalnix.
Fabien accepted this revision.Jan 8 2021, 14:36
This revision is now accepted and ready to land.Jan 8 2021, 14:36
Closed by commit rABC0dddb517c3f8: [cashtab] Upgrade webpack modules (authored by deadalnix). · Explain WhyJan 8 2021, 14:41
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC0dddb517c3f8: [cashtab] Upgrade webpack modules.

Revision Contents
Changeset List

PathSize
web/
cashtab/
601 lines
16 lines

Diff 26792

View Options

web/cashtab/package-lock.json

Loading...
View Options

web/cashtab/package.json

Loading...