Page MenuHomePhabricator

[cashtab] Upgrade webpack modules
ClosedPublic

Authored by deadalnix on Jan 7 2021, 18:56.

Details

Reviewers
bytesofman
Fabien
Group Reviewers
Restricted Project
Commits
rABC0dddb517c3f8: [cashtab] Upgrade webpack modules
Summary

As per title

Test Plan
npm run start

Check the app works.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bytesofman requested changes to this revision.Jan 7 2021, 19:44
bytesofman added a subscriber: bytesofman.

I'm able to get npm install to work here with node v15.3.0 or v15.4.0 and npm v7.0.15 (but package-lock.json is different)

npm v7.3.0 runs into dependency issue without --legacy-peer-deps

What version of node and npm did you use for this diff?

Could you please run

cd cashtab/web
rm -rf node_modules
rm package-lock-json
npm i

and submit?

This revision now requires changes to proceed.Jan 7 2021, 19:44
In D8838#202946, @josephroyking wrote:

I'm able to get npm install to work here with node v15.3.0 or v15.4.0 and npm v7.0.15 (but package-lock.json is different)

npm v7.3.0 runs into dependency issue without --legacy-peer-deps

What version of node and npm did you use for this diff?

Could you please run

cd cashtab/web
rm -rf node_modules
rm package-lock-json
npm i

and submit?

Doing this kind of crap is EXACTLY what CI is for. Why are you doing it?

Updated package-lock and rebase

bytesofman requested changes to this revision.Jan 8 2021, 13:54

npm i needs to be run to update package-lock.json after this rebase as there are additional npm modules.

As you point out, this could be a CI change; enforce npm i before any arc diff, or even npm run build to make sure it builds.

This revision now requires changes to proceed.Jan 8 2021, 13:54

Never mind, I just ran the start command from the wrong folder. This is good to go.

This revision is now accepted and ready to land.Jan 8 2021, 13:57
This comment was removed by deadalnix.
This revision is now accepted and ready to land.Jan 8 2021, 14:36
This revision was automatically updated to reflect the committed changes.