Page MenuHomePhabricator
Differential D907

A pack of nits in the wallet.
ClosedPublic
Actions

Authored by deadalnix on Jan 6 2018, 23:32.

Details

Reviewers
schancel
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING9aa8705c0c26: A pack of nits in the wallet.
rABC9aa8705c0c26: A pack of nits in the wallet.
Summary

As per title.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
walletnits
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1535
Build 1535: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jan 6 2018, 23:32
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 6 2018, 23:32
deadalnix added a child revision: D908: Refactor ZapWalletTxes to avoid layer violations.Jan 6 2018, 23:39
jasonbcox accepted this revision.Jan 7 2018, 02:01
jasonbcox added a subscriber: jasonbcox.

LGTM

src/wallet/walletdb.cpp
758–760

Just for my own understanding: What's the reasoning behind removing the else here and in other places? Is it only included when it's necessary for the logic?

This revision is now accepted and ready to land.Jan 7 2018, 02:01
deadalnix added inline comments.Jan 7 2018, 02:53
src/wallet/walletdb.cpp
758–760

http://www.yegor256.com/2015/01/21/if-then-throw-else.html?2015-03

Closed by commit rABC9aa8705c0c26: A pack of nits in the wallet. (authored by deadalnix). · Explain WhyJan 7 2018, 02:54
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
wallet/
52 lines
68 lines
149 lines

Diff 2384

View Options

src/wallet/db.h

Loading...
View Options

src/wallet/db.cpp

Loading...
View Options

src/wallet/walletdb.cpp

Loading...