Page MenuHomePhabricator
Differential D9560

Rename `tx` to `inv` in the TxRequestTracker
ClosedPublic
Actions

Authored by Fabien on May 20 2021, 19:09.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Maniphest Tasks
Restricted Maniphest Task
Commits
rABC90a7b4e33239: Rename `tx` to `inv` in the TxRequestTracker
Summary

This is a massive renaming of the TxRequestTracker:

  • tx => inv
  • Tx => Inv
  • (a) transaction => (an) inventory
  • transactions => inventories
  • Various minor fixups in comments

Note: the public names are not updated so the API is left unchanged and
there is no change in behavior.

Depends on D9563.

Test Plan
ninja all check-all
./test/functional/test_runner.py p2p_tx_download

Diff Detail

Event Timeline

Fabien created this revision.May 20 2021, 19:09
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 20 2021, 19:09
Fabien requested review of this revision.May 20 2021, 19:09
Fabien added a child revision: D9561: Rename txrequest.h/cpp to invrequest.h/cpp.May 20 2021, 19:17
Harbormaster completed remote builds in B15770: Diff 28557.May 20 2021, 19:32
deadalnix requested changes to this revision.May 20 2021, 22:43
deadalnix added a subscriber: deadalnix.

I think you'll find this doesn't working once you keep the private implementation - which you should.

This revision now requires changes to proceed.May 20 2021, 22:43
Mengerian added a task: Restricted Maniphest Task.May 21 2021, 17:08
Fabien updated this revision to Diff 28570.May 21 2021, 21:25

Rebase on top of D9563

Fabien edited the summary of this revision. (Show Details)May 21 2021, 21:26
Fabien added a parent revision: D9563: Turn InvRequestTracker into a template class.
Fabien removed a parent revision: D9559: Move all implementation details from the TxRequestTracker to the header.
Harbormaster completed remote builds in B15781: Diff 28570.May 21 2021, 21:40
deadalnix accepted this revision.May 26 2021, 15:42
This revision is now accepted and ready to land.May 26 2021, 15:42
Closed by commit rABC90a7b4e33239: Rename `tx` to `inv` in the TxRequestTracker (authored by Fabien). · Explain WhyMay 27 2021, 18:22
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC90a7b4e33239: Rename `tx` to `inv` in the TxRequestTracker.

Revision Contents
Changeset List

PathSize
src/
383 lines

Diff 28557

View Options

src/txrequest.h

Loading...