Page MenuHomePhabricator

Rename `tx` to `inv` in the TxRequestTracker
ClosedPublic

Authored by Fabien on May 20 2021, 19:09.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Maniphest Tasks
Restricted Maniphest Task
Commits
rABC90a7b4e33239: Rename `tx` to `inv` in the TxRequestTracker
Summary

This is a massive renaming of the TxRequestTracker:

  • tx => inv
  • Tx => Inv
  • (a) transaction => (an) inventory
  • transactions => inventories
  • Various minor fixups in comments

Note: the public names are not updated so the API is left unchanged and
there is no change in behavior.

Depends on D9563.

Test Plan
ninja all check-all
./test/functional/test_runner.py p2p_tx_download

Event Timeline

Fabien requested review of this revision.May 20 2021, 19:09
deadalnix requested changes to this revision.May 20 2021, 22:43
deadalnix added a subscriber: deadalnix.

I think you'll find this doesn't working once you keep the private implementation - which you should.

This revision now requires changes to proceed.May 20 2021, 22:43
Mengerian added a task: Restricted Maniphest Task.May 21 2021, 17:08
This revision is now accepted and ready to land.May 26 2021, 15:42
This revision was automatically updated to reflect the committed changes.