Page MenuHomePhabricator
Differential D9590

Extract out the inventory logging to a lambda
ClosedPublic
Actions

Authored by Fabien on May 26 2021, 19:46.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC229e3d125262: Extract out the inventory logging to a lambda
Summary

This is a little deduplication that can be leveraged when introducing
proofs inventories.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.May 26 2021, 19:46
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 26 2021, 19:46
Fabien requested review of this revision.May 26 2021, 19:46
Fabien added a child revision: D9591: Split the inv message reception processing in logical blocks by inv type.
Harbormaster completed remote builds in B15820: Diff 28624.May 26 2021, 19:59
deadalnix accepted this revision.May 26 2021, 21:04
deadalnix added a subscriber: deadalnix.

I'm not super convinced this is really a plus, as it adds an indirection to something that just does one thing.

This revision is now accepted and ready to land.May 26 2021, 21:04
Closed by commit rABC229e3d125262: Extract out the inventory logging to a lambda (authored by Fabien). · Explain WhyMay 27 2021, 08:01
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC229e3d125262: Extract out the inventory logging to a lambda.

Revision Contents
Changeset List

PathSize
src/
13 lines

Diff 28631

View Options

src/net_processing.cpp

Loading...