[avalanche] Do not bucket brigade proof registration
ClosedPublic
Actions

Authored by Fabien on Jul 12 2021, 14:11.

Details

Reviewers

PiRK
majcosta

Group Reviewers

Restricted Project

Commits

rABC7cb36e0d6975: [avalanche] Do not bucket brigade proof registration

Summary

There are few callsites, it can easily be avoided.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_remove_addproof

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16155
Build 32183: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 32182: arc lint + arc unit

Event Timeline

Fabien created this revision.Jul 12 2021, 14:11

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 12 2021, 14:11

Fabien requested review of this revision.Jul 12 2021, 14:11

Harbormaster completed remote builds in B16155: Diff 29142.Jul 12 2021, 14:42

Fabien added a child revision: D9769: [avalanche] Do not bucket brigade (orphan) proof accessor.Jul 12 2021, 14:48

PiRK accepted this revision.Jul 12 2021, 17:25

This revision is now accepted and ready to land.Jul 12 2021, 17:25

majcosta accepted this revision.Jul 12 2021, 17:29

Closed by commit rABC7cb36e0d6975: [avalanche] Do not bucket brigade proof registration (authored by Fabien). · Explain WhyJul 13 2021, 06:29

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC7cb36e0d6975: [avalanche] Do not bucket brigade proof registration.

Fabien mentioned this in D9791: [avalanche] Fix a lock order inversion on shutdown.Jul 15 2021, 09:56

Fabien mentioned this in rABC3e097cd62491: [avalanche] Fix a lock order inversion on shutdown.Jul 15 2021, 10:40

Revision Contents
Changeset List

Path

Size

src/

avalanche/

processor.h

1 line

processor.cpp

5 lines

test/

processor_tests.cpp

14 lines

net_processing.cpp

31 lines

rpc/

avalanche.cpp

11 lines

Diff 29142

View Options

src/avalanche/processor.h

View Options

src/avalanche/processor.cpp

View Options

src/avalanche/test/processor_tests.cpp

View Options

src/net_processing.cpp

View Options

[avalanche] Do not bucket brigade proof registrationClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 29142

src/avalanche/processor.h

src/avalanche/processor.cpp

src/avalanche/test/processor_tests.cpp

src/net_processing.cpp

src/rpc/avalanche.cpp

[avalanche] Do not bucket brigade proof registration
ClosedPublic
Actions

Revision Contents
Changeset List