Differential D9871
ecash: make XEC/eCash the default Authored by majcosta on Aug 12 2021, 21:56.
Details
after this, anyone wanting to use the old BCHA default unit and CashAddr prefixes is required to start the node with ecash=0 ninja all check check-functional
Diff Detail
Event TimelineComment Actions Can we change the default and remove the option in two separate steps? That will make things easier for people who aren't ready. Comment Actions Looks like the Diff summary has a mistake, it should say: after this, anyone wanting to use the old BCHA default unit and CashAddr prefixes is required to start the node with ecash=0 (rather the ecash=1) Comment Actions addressed feedback. I'd rather change the debug text on abc_rpc_ecash.py, if anything that's another test that will break if someone unwittingly changes the ecash default, which I like Comment Actions Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.
Tail of the build log: [386/442] Running utility command for check-bitcoin-settings_tests [387/442] bitcoin: testing streams_tests [388/442] bitcoin: testing scriptpubkeyman_tests [389/442] bitcoin: testing timedata_tests [390/442] Running utility command for check-bitcoin-streams_tests [391/442] Running utility command for check-bitcoin-scriptpubkeyman_tests [392/442] Running utility command for check-bitcoin-timedata_tests [393/442] bitcoin: testing uint256_tests [394/442] bitcoin: testing txvalidationcache_tests [395/442] Running utility command for check-bitcoin-uint256_tests [396/442] Running utility command for check-bitcoin-txvalidationcache_tests [397/442] bitcoin: testing script_standard_tests [398/442] Running utility command for check-bitcoin-script_standard_tests [399/442] bitcoin: testing wallet_tests [400/442] bitcoin: testing serialize_tests [401/442] Running utility command for check-bitcoin-wallet_tests [402/442] Running utility command for check-bitcoin-serialize_tests [403/442] bitcoin: testing getarg_tests [404/442] Running utility command for check-pow-aserti32d_tests [405/442] bitcoin: testing schnorr_tests [406/442] Running pow test suite PASSED: pow test suite [407/442] Running utility command for check-bitcoin-getarg_tests [408/442] bitcoin: testing blockcheck_tests [409/442] Running utility command for check-bitcoin-schnorr_tests [410/442] Running utility command for check-seeder-message_writer_tests [411/442] bitcoin: testing versionbits_tests [412/442] bitcoin: testing radix_tests [413/442] Running utility command for check-bitcoin-blockcheck_tests [414/442] Running utility command for check-bitcoin-versionbits_tests [415/442] Running utility command for check-bitcoin-radix_tests [416/442] seeder: testing p2p_messaging_tests [417/442] seeder: testing parse_name_tests [418/442] Running utility command for check-seeder-p2p_messaging_tests [419/442] Running utility command for check-seeder-parse_name_tests [420/442] Running seeder test suite PASSED: seeder test suite [421/442] bitcoin: testing monolith_opcodes_tests [422/442] Running utility command for check-bitcoin-monolith_opcodes_tests [423/442] bitcoin: testing transaction_tests [424/442] bitcoin: testing validation_tests [425/442] Running utility command for check-bitcoin-transaction_tests [426/442] Running utility command for check-bitcoin-validation_tests [427/442] bitcoin: testing crypto_tests [428/442] Running utility command for check-bitcoin-crypto_tests [429/442] bitcoin: testing validation_block_tests [430/442] Running utility command for check-bitcoin-validation_block_tests [431/442] bitcoin: testing skiplist_tests [432/442] Running utility command for check-bitcoin-skiplist_tests [433/442] bitcoin: testing op_reversebytes_tests [434/442] Running utility command for check-bitcoin-op_reversebytes_tests [435/442] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/paymentservertests.cpp.o [436/442] Linking CXX executable src/qt/test/test_bitcoin-qt [437/442] bitcoin-qt: testing test_bitcoin-qt [438/442] Running bitcoin-qt test suite PASSED: bitcoin-qt test suite [439/442] bitcoin: testing coins_tests [440/442] Running utility command for check-bitcoin-coins_tests ninja: build stopped: cannot make progress due to previous errors. Build build-clang-tidy failed with exit code 1
| ||||||||||||||