In D17366#394875, @PiRK wrote:

In D17366#394869, @teamcity wrote:

Build Bitcoin ABC Diffs / Diff Testing (ecash-lib-integration-tests) failed.

Unrelated. Looks like a permission error when creating a directory

20:03:09     File "/work/abc-ci-builds/ecash-lib-integration-tests/test/functional/test_runner.py", line 1094, in <module>
20:03:09       main()
20:03:09     File "/work/abc-ci-builds/ecash-lib-integration-tests/test/functional/test_runner.py", line 361, in main
20:03:09       os.makedirs(tmpdir)
20:03:09     File "<frozen os>", line 225, in makedirs
20:03:09     FileExistsError: [Errno 17] File exists: '/work/abc-ci-builds/ecash-lib-integration-tests/test/tmp/test_runner_₿₵_🏃_20241217_200307'

Just bump the value because predicting it is proving to be difficult and time consuming

In D17366#394869, @teamcity wrote:

Build Bitcoin ABC Diffs / Diff Testing (ecash-lib-integration-tests) failed.

Unrelated. Looks like a permission error when creating a directory

custom error code and test for wrong type for boolean arg

i missed one

feedback

TIL chage

Note that I also tried a form for the macro that check both min and max check_number_of_params!(params, 1, 2); but then I ran into a clippy warning when I added check_number_of_params!(params, 0, 0); in the server.ping handler

line length nit

address clippy's complaint

feedback

@bot build-bitcoinsuite-chronik-client

so it looks like we don't need to use serde_json::Value; in the module that implement try_from(value: &'_ serde_json::Value), but we still need to have the crate as a depencency (Cargo.[toml/lock])

change toLegacyAddress behavior to throw if called with legacy address, move legacy functions to legacyaddr.ts, define toLegacyAddress in address.ts, organize and update tests accordingly

Not sure why the build claims serde_json:: Value is unused in txid.rs, will investigate

Use a debug RPC. Waiting for getavalanchepeerinfo is not sufficient here because its possible for this value to be updated before the contender is added to the cache.

use is_none() isntead of match

take a reference for TryFrom, use it also in transaction_get (minor behavior change in the error message, because now we have one less line that can raise a variant on the same error message)

Added CI integration (build-configurations.yml), added copyright licenses, changed server and reduced Tokio syntax.

not the issue

rebase after reducing the port range in D17314

rebase after reducing the port range in D17314

rebase after reducing the port range in D17314

@bot build-linux64 build-linux-aarch64 build-chronik build-chronik-plugins

reduce port range to 3000 to keep the same effective range of ports