HomePhabricator

Recent Activity
ActivePublic

Recent Activity

Today

PiRK updated the diff for D17925: rpc: Make pruneheight also reflect undo data presence.

rebase

Fri, Apr 11, 16:37
teamcity closed T3780: Build Bitcoin-ABC / Master / Default Extended Tests is broken. as Resolved.
Fri, Apr 11, 16:25
PiRK updated the diff for D17924: refactor, blockstorage: Generalize GetFirstStoredBlock.

pass status by const ref

Fri, Apr 11, 16:23
roqqit requested changes to D17832: [avalanche] Poll for the transactions that didn't make it into the last block.
Fri, Apr 11, 15:41
roqqit closed D17923: [avalanche] Wait for the local winner instead of immediately asserting.
Fri, Apr 11, 15:25
roqqit committed rABCc50432fcd1a8: [avalanche] Wait for the local winner instead of immediately asserting (authored by roqqit).
[avalanche] Wait for the local winner instead of immediately asserting
Fri, Apr 11, 15:25
Fabien requested changes to D17924: refactor, blockstorage: Generalize GetFirstStoredBlock.
Fri, Apr 11, 14:11
PiRK updated the summary of D17924: refactor, blockstorage: Generalize GetFirstStoredBlock.
Fri, Apr 11, 13:06
PiRK updated the summary of D17924: refactor, blockstorage: Generalize GetFirstStoredBlock.
Fri, Apr 11, 13:05
PiRK updated the diff for D17924: refactor, blockstorage: Generalize GetFirstStoredBlock.

include <functional>

Fri, Apr 11, 13:00
teamcity updated the summary of D17925: rpc: Make pruneheight also reflect undo data presence.
Fri, Apr 11, 12:58
PiRK requested review of D17925: rpc: Make pruneheight also reflect undo data presence.
Fri, Apr 11, 12:58
teamcity updated the summary of D17924: refactor, blockstorage: Generalize GetFirstStoredBlock.
Fri, Apr 11, 12:53
PiRK requested review of D17924: refactor, blockstorage: Generalize GetFirstStoredBlock.
Fri, Apr 11, 12:53
Fabien updated the diff for D17832: [avalanche] Poll for the transactions that didn't make it into the last block.

Add children first to optimize the polls

Fri, Apr 11, 12:43
teamcity closed T3779: Build Bitcoin-ABC / CashTab / CashTab Unit Tests is broken. as Resolved.
Fri, Apr 11, 09:09
PiRK closed D17922: test: add coverage for rpc error when trying to rescan beyond pruned data.
Fri, Apr 11, 09:02
PiRK closed D17921: rpc: Enable wallet import on pruned nodes.
Fri, Apr 11, 09:02
PiRK committed rABC073ac4d70ec0: test: add coverage for rpc error when trying to rescan beyond pruned data (authored by brunoerg <brunoely.gc@gmail.com>).
test: add coverage for rpc error when trying to rescan beyond pruned data
Fri, Apr 11, 09:02
PiRK committed rABCa6ef9e78d417: test: run feature_pruning.py without wallet compiled (authored by PiRK).
test: run feature_pruning.py without wallet compiled
Fri, Apr 11, 09:02
PiRK closed D17920: test: run feature_pruning.py without wallet compiled.
Fri, Apr 11, 09:02
PiRK committed rABC302a7e7f9443: rpc: Enable wallet import on pruned nodes (authored by Aurèle Oulès <aurele@oules.com>).
rpc: Enable wallet import on pruned nodes
Fri, Apr 11, 09:02
PiRK committed rABCa1687cb9c668: test: stop node before calling assert_start_raises_init_error (authored by Martin Zumsande <mzumsande@gmail.com>).
test: stop node before calling assert_start_raises_init_error
Fri, Apr 11, 09:01
PiRK closed D17919: test: stop node before calling assert_start_raises_init_error.
Fri, Apr 11, 09:01
Fabien accepted D17922: test: add coverage for rpc error when trying to rescan beyond pruned data.
Fri, Apr 11, 08:54
Fabien accepted D17921: rpc: Enable wallet import on pruned nodes.
Fri, Apr 11, 08:54
Fabien requested changes to D17913: [chronik-client] Added a mechanism for automatically selecting the fastest responding node, supporting two strategies: AsOrdered and ClosestFirst..
Fri, Apr 11, 08:41
PiRK accepted D17923: [avalanche] Wait for the local winner instead of immediately asserting.
Fri, Apr 11, 06:56

Yesterday

roqqit requested review of D17923: [avalanche] Wait for the local winner instead of immediately asserting.
Thu, Apr 10, 23:41
teamcity added a comment to D17913: [chronik-client] Added a mechanism for automatically selecting the fastest responding node, supporting two strategies: AsOrdered and ClosestFirst..
Thu, Apr 10, 23:38
teamcity added a comment to D17913: [chronik-client] Added a mechanism for automatically selecting the fastest responding node, supporting two strategies: AsOrdered and ClosestFirst..
Thu, Apr 10, 23:38
alitayin added a comment to D17913: [chronik-client] Added a mechanism for automatically selecting the fastest responding node, supporting two strategies: AsOrdered and ClosestFirst..

// Using the static method with strategy
const chronik = await ChronikClient.useStrategy(

ConnectionStrategy.ClosestFirst, 
urls,
maxConcurrentTests // optional parameter, default is 20

);

Thu, Apr 10, 23:34
alitayin updated the diff for D17913: [chronik-client] Added a mechanism for automatically selecting the fastest responding node, supporting two strategies: AsOrdered and ClosestFirst..

Node selection is implemented using static methods in chronikclient while maintaining consistency with existing methods. Removed the original npm list
test. Moved measureWebsocketLatency and sortNodesByLatency to chronikclient.ts

Thu, Apr 10, 23:28
tobias_ruck requested changes to D17822: [ecash-wallet] Add fluent API for building and broadcasting txs.
Thu, Apr 10, 23:06
tobias_ruck added inline comments to D17822: [ecash-wallet] Add fluent API for building and broadcasting txs.
Thu, Apr 10, 23:06
teamcity closed T3781: Build Bitcoin-ABC / Master / Coverage is broken. as Resolved.
Thu, Apr 10, 22:57
teamcity triaged T3781: Build Bitcoin-ABC / Master / Coverage is broken. as Unbreak Now! priority.
Thu, Apr 10, 22:21
teamcity triaged T3780: Build Bitcoin-ABC / Master / Default Extended Tests is broken. as Unbreak Now! priority.
Thu, Apr 10, 22:20
teamcity triaged T3779: Build Bitcoin-ABC / CashTab / CashTab Unit Tests is broken. as Unbreak Now! priority.
Thu, Apr 10, 22:03
PiRK closed D17918: wallet: validationinterface: only handle active chain notifications.
Thu, Apr 10, 21:55
PiRK committed rABC845f8476e440: wallet: validationinterface: only handle active chain notifications (authored by James O'Beirne <james.obeirne@pm.me>).
wallet: validationinterface: only handle active chain notifications
Thu, Apr 10, 21:55
teamcity updated the summary of D17922: test: add coverage for rpc error when trying to rescan beyond pruned data.
Thu, Apr 10, 21:35
PiRK requested review of D17922: test: add coverage for rpc error when trying to rescan beyond pruned data.
Thu, Apr 10, 21:35
PiRK updated the diff for D17921: rpc: Enable wallet import on pruned nodes.

we need to specify the block version in feature_pruning as well (missing backport that specifies version 4 as the default in create_block)

Thu, Apr 10, 21:32
roqqit closed D17917: [avalanche] Remove requirement that local staking rewards have to be computed in order to poll contenders.
Thu, Apr 10, 21:21
roqqit committed rABCe0776c77fd38: [avalanche] Remove requirement that local staking rewards have to be computed… (authored by roqqit).
[avalanche] Remove requirement that local staking rewards have to be computed…
Thu, Apr 10, 21:21
roqqit accepted D17920: test: run feature_pruning.py without wallet compiled.
Thu, Apr 10, 21:15
teamcity updated the summary of D17921: rpc: Enable wallet import on pruned nodes.
Thu, Apr 10, 20:59
PiRK requested review of D17921: rpc: Enable wallet import on pruned nodes.
Thu, Apr 10, 20:59
PiRK updated the test plan for D17920: test: run feature_pruning.py without wallet compiled.
Thu, Apr 10, 20:58
teamcity updated the summary of D17920: test: run feature_pruning.py without wallet compiled.
Thu, Apr 10, 20:00
PiRK requested review of D17920: test: run feature_pruning.py without wallet compiled.
Thu, Apr 10, 20:00
Fabien accepted D17919: test: stop node before calling assert_start_raises_init_error.
Thu, Apr 10, 19:56
teamcity updated the summary of D17919: test: stop node before calling assert_start_raises_init_error.
Thu, Apr 10, 19:55
PiRK requested review of D17919: test: stop node before calling assert_start_raises_init_error.
Thu, Apr 10, 19:55
Fabien accepted D17917: [avalanche] Remove requirement that local staking rewards have to be computed in order to poll contenders.
Thu, Apr 10, 19:55
Fabien planned changes to D17832: [avalanche] Poll for the transactions that didn't make it into the last block.
Thu, Apr 10, 19:54
roqqit added inline comments to D17917: [avalanche] Remove requirement that local staking rewards have to be computed in order to poll contenders.
Thu, Apr 10, 18:04
Fabien accepted D17918: wallet: validationinterface: only handle active chain notifications.
Thu, Apr 10, 13:28
teamcity awarded D17918: wallet: validationinterface: only handle active chain notifications a Haypence token.
Thu, Apr 10, 13:04
Fabien added a comment to D17918: wallet: validationinterface: only handle active chain notifications.

@bot build-chronik

Thu, Apr 10, 13:04
PiRK updated the diff for D17918: wallet: validationinterface: only handle active chain notifications.

remove debugging print

Thu, Apr 10, 13:02
teamcity updated the summary of D17918: wallet: validationinterface: only handle active chain notifications.
Thu, Apr 10, 12:57
PiRK requested review of D17918: wallet: validationinterface: only handle active chain notifications.
Thu, Apr 10, 12:57
Fabien requested changes to D17913: [chronik-client] Added a mechanism for automatically selecting the fastest responding node, supporting two strategies: AsOrdered and ClosestFirst..
Thu, Apr 10, 10:24
teamcity added a comment to D17913: [chronik-client] Added a mechanism for automatically selecting the fastest responding node, supporting two strategies: AsOrdered and ClosestFirst..
Thu, Apr 10, 10:11
teamcity added a comment to D17913: [chronik-client] Added a mechanism for automatically selecting the fastest responding node, supporting two strategies: AsOrdered and ClosestFirst..
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
Thu, Apr 10, 10:07
alitayin updated the diff for D17913: [chronik-client] Added a mechanism for automatically selecting the fastest responding node, supporting two strategies: AsOrdered and ClosestFirst..

After this modification, it no longer dynamically selects the best node. Instead, it rearranges the
node order only once during initialization. Removed the URL string and kept only the array to maintain consistency with chronikclient.
And use as-order as default

Thu, Apr 10, 10:01
teamcity added a comment to D17913: [chronik-client] Added a mechanism for automatically selecting the fastest responding node, supporting two strategies: AsOrdered and ClosestFirst..
Thu, Apr 10, 09:20
teamcity added a comment to D17913: [chronik-client] Added a mechanism for automatically selecting the fastest responding node, supporting two strategies: AsOrdered and ClosestFirst..
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
Thu, Apr 10, 09:16
alitayin updated the diff for D17913: [chronik-client] Added a mechanism for automatically selecting the fastest responding node, supporting two strategies: AsOrdered and ClosestFirst..

After this modification, it no longer dynamically selects the best node. Instead, it rearranges the node order only once during
initialization. Removed the URL string and kept only the array to maintain consistency with chronikclient.

Thu, Apr 10, 09:10
Fabien added inline comments to D17917: [avalanche] Remove requirement that local staking rewards have to be computed in order to poll contenders.
Thu, Apr 10, 08:12

Wed, Apr 9

roqqit requested review of D17917: [avalanche] Remove requirement that local staking rewards have to be computed in order to poll contenders.
Wed, Apr 9, 22:22
Fabien closed D17831: [avalanche] Limit the finalized txs radix tree size so it always fits in the next block.
Wed, Apr 9, 18:08
Fabien committed rABCa31a4f223f02: [avalanche] Limit the finalized txs radix tree size so it always fits in the… (authored by Fabien).
[avalanche] Limit the finalized txs radix tree size so it always fits in the…
Wed, Apr 9, 18:08
Fabien closed D17836: [avalanche] Improve lock annotations for AvalancheFinalizeBlock.
Wed, Apr 9, 18:04
Fabien committed rABC48b7eae57e55: [avalanche] Improve lock annotations for AvalancheFinalizeBlock (authored by Fabien).
[avalanche] Improve lock annotations for AvalancheFinalizeBlock
Wed, Apr 9, 18:04
roqqit accepted D17831: [avalanche] Limit the finalized txs radix tree size so it always fits in the next block.
Wed, Apr 9, 16:37
roqqit accepted D17836: [avalanche] Improve lock annotations for AvalancheFinalizeBlock.
Wed, Apr 9, 16:34
roqqit closed D17912: Add Shibusawa activation logic.
Wed, Apr 9, 15:43
roqqit committed rABC8b148e37eb56: Add Shibusawa activation logic (authored by roqqit).
Add Shibusawa activation logic
Wed, Apr 9, 15:43
Fabien updated the diff for D17832: [avalanche] Poll for the transactions that didn't make it into the last block.

Rebase

Wed, Apr 9, 14:27
Fabien updated the diff for D17831: [avalanche] Limit the finalized txs radix tree size so it always fits in the next block.

Feedback

Wed, Apr 9, 14:24
Fabien updated the diff for D17836: [avalanche] Improve lock annotations for AvalancheFinalizeBlock.

Rebase

Wed, Apr 9, 14:00
Fabien requested changes to D17886: [chronik] Add failover_proxy to bitcoinsuite-chronik-client.

Apart from a few nits and bad tests this code looks good.

Wed, Apr 9, 13:33
Fabien created Image Macro "however".
Wed, Apr 9, 13:21
Fabien requested changes to D17913: [chronik-client] Added a mechanism for automatically selecting the fastest responding node, supporting two strategies: AsOrdered and ClosestFirst..

As discussed offline the approach here is wrong. This code is trying to do load balancing, but this is a bad idea and should be handled server side and not client side: the server knows its load but the client can't.

Wed, Apr 9, 13:00
hazzarust updated the diff for D17886: [chronik] Add failover_proxy to bitcoinsuite-chronik-client.

Made url idiomatic hehe, removed hex import ::* to make more readable, made the other changes suggested

Wed, Apr 9, 11:37
PiRK accepted D17912: Add Shibusawa activation logic.

it looks good to me. You could also remove the "-schumpeteractivationtime" stuff, it looks like now it is no longer used outside of tests

Wed, Apr 9, 08:49
PiRK closed D17911: test: Introduce ensure_for helper.
Wed, Apr 9, 08:46
PiRK committed rABCf881f585a838: test: Introduce ensure_for helper (authored by Fabian Jahr <fjahr@protonmail.com>).
test: Introduce ensure_for helper
Wed, Apr 9, 08:46
alitayin requested review of D17913: [chronik-client] Added a mechanism for automatically selecting the fastest responding node, supporting two strategies: AsOrdered and ClosestFirst..
Wed, Apr 9, 08:25
alitayin added a comment to D17913: [chronik-client] Added a mechanism for automatically selecting the fastest responding node, supporting two strategies: AsOrdered and ClosestFirst..

I have tested the modified chronik-client locally and it switches smoothly. Perhaps I could deploy it on an actual test domain for public testing?

Wed, Apr 9, 08:24

Tue, Apr 8

bytesofman requested changes to D17913: [chronik-client] Added a mechanism for automatically selecting the fastest responding node, supporting two strategies: AsOrdered and ClosestFirst..

without benchmarking this is difficult to review. you may need to run this as a custom version on some apps and see how it behaves in prod.

Tue, Apr 8, 23:48
alitayin requested review of D17913: [chronik-client] Added a mechanism for automatically selecting the fastest responding node, supporting two strategies: AsOrdered and ClosestFirst..
Tue, Apr 8, 19:32
roqqit requested review of D17912: Add Shibusawa activation logic.
Tue, Apr 8, 18:52
roqqit accepted D17911: test: Introduce ensure_for helper.
Tue, Apr 8, 15:37
tobias_ruck requested changes to D17886: [chronik] Add failover_proxy to bitcoinsuite-chronik-client.
Tue, Apr 8, 14:15
teamcity updated the summary of D17911: test: Introduce ensure_for helper.
Tue, Apr 8, 13:49
PiRK requested review of D17911: test: Introduce ensure_for helper.
Tue, Apr 8, 13:49

Panel Used By

Event Timeline

zawagner renamed this panel from to Recent Activity.Apr 18 2018, 03:15
zawagner edited an edge.