Today
rebase
pass status by const ref
include <functional>
Add children first to optimize the polls
Yesterday
// Using the static method with strategy
const chronik = await ChronikClient.useStrategy(
ConnectionStrategy.ClosestFirst, urls, maxConcurrentTests // optional parameter, default is 20
);
Node selection is implemented using static methods in chronikclient while maintaining consistency with existing methods. Removed the original npm list
test. Moved measureWebsocketLatency and sortNodesByLatency to chronikclient.ts
we need to specify the block version in feature_pruning as well (missing backport that specifies version 4 as the default in create_block)
@bot build-chronik
remove debugging print
After this modification, it no longer dynamically selects the best node. Instead, it rearranges the
node order only once during initialization. Removed the URL string and kept only the array to maintain consistency with chronikclient.
And use as-order as default
After this modification, it no longer dynamically selects the best node. Instead, it rearranges the node order only once during
initialization. Removed the URL string and kept only the array to maintain consistency with chronikclient.
Wed, Apr 9
Rebase
Feedback
Rebase
Apart from a few nits and bad tests this code looks good.
As discussed offline the approach here is wrong. This code is trying to do load balancing, but this is a bad idea and should be handled server side and not client side: the server knows its load but the client can't.
Made url idiomatic hehe, removed hex import ::* to make more readable, made the other changes suggested
it looks good to me. You could also remove the "-schumpeteractivationtime" stuff, it looks like now it is no longer used outside of tests
I have tested the modified chronik-client locally and it switches smoothly. Perhaps I could deploy it on an actual test domain for public testing?
Tue, Apr 8
without benchmarking this is difficult to review. you may need to run this as a custom version on some apps and see how it behaves in prod.
Panel Used By
Dashboard | zawagner's Dashboard |