HomePhabricator

Recent Activity
ActivePublic

Recent Activity

Today

bytesofman published D16056: [Cashtab] Patch tx history rendering of NFT Collection genesis txs for review.
Fri, Apr 26, 12:17
bytesofman abandoned D16050: [ecash-lib] checksum for ecash-lib-wasm in CI build.

the goal here is to get ecash-lib published to npm in CI, this approach does not really support that goal

Fri, Apr 26, 11:56
Fabien requested changes to D16050: [ecash-lib] checksum for ecash-lib-wasm in CI build.

You want to check the hash of the binary to be loaded by the lib. There is no point checking it during the tests (where it's expected to change) and no point documenting the value, it will be out of sync in no time.

Fri, Apr 26, 08:59

Yesterday

tobias_ruck closed D16053: [ecash-lib] Enable NodeJS support.
Thu, Apr 25, 23:10
tobias_ruck committed rABCcaf3b259a611: [ecash-lib] Enable NodeJS support (authored by tobias_ruck).
[ecash-lib] Enable NodeJS support
Thu, Apr 25, 23:10
bytesofman accepted D16053: [ecash-lib] Enable NodeJS support.

You can use ecash-lib without TypeScript in CashTab!

Thu, Apr 25, 22:33
bytesofman added a comment to D16053: [ecash-lib] Enable NodeJS support.

The implication is that the tests now don't have to load the WASM themselves anymore, and we can remove this code from the tests.

Thu, Apr 25, 22:31
bytesofman published D16054: [Cashtab + token-server] Bump icon upload size and validate icon size before token creation for review.
Thu, Apr 25, 22:28
tobias_ruck added inline comments to D16053: [ecash-lib] Enable NodeJS support.
Thu, Apr 25, 20:10
tobias_ruck added a comment to D16053: [ecash-lib] Enable NodeJS support.

But we still need to make sure it is in place before we compile the typescript and publish the npm package, right?

Yes, of course.

Thu, Apr 25, 20:10
tobias_ruck closed D16052: [ecash-lib] Move ecash-lib-wasm back to root workspace.
Thu, Apr 25, 18:00
tobias_ruck committed rABC2324879c48f3: [ecash-lib] Move ecash-lib-wasm back to root workspace (authored by tobias_ruck).
[ecash-lib] Move ecash-lib-wasm back to root workspace
Thu, Apr 25, 18:00
Fabien accepted D16052: [ecash-lib] Move ecash-lib-wasm back to root workspace.
Thu, Apr 25, 17:49
bytesofman retitled D16050: [ecash-lib] checksum for ecash-lib-wasm in CI build from [ecash-lib] Add a pre-build step to build ecash-lib-wasm to [ecash-lib] checksum for ecash-lib-wasm in CI build.
Thu, Apr 25, 17:47
bytesofman requested changes to D16053: [ecash-lib] Enable NodeJS support.

The implication is that the tests now don't have to load the WASM themselves anymore, and we can remove this code from the tests.

Thu, Apr 25, 17:46
teamcity awarded D16052: [ecash-lib] Move ecash-lib-wasm back to root workspace a Mountain of Wealth token.
Thu, Apr 25, 17:34
Fabien added a comment to D16052: [ecash-lib] Move ecash-lib-wasm back to root workspace.

@bot build-linux-arm

Thu, Apr 25, 17:33
bytesofman updated the diff for D16050: [ecash-lib] checksum for ecash-lib-wasm in CI build.

update readme, back out the .gitignore change

Thu, Apr 25, 17:32
bytesofman updated the diff for D16050: [ecash-lib] checksum for ecash-lib-wasm in CI build.

update checksum to what was observed in CI

Thu, Apr 25, 17:26
bytesofman added a comment to D16050: [ecash-lib] checksum for ecash-lib-wasm in CI build.

check if CI hash is 3f42174043db297043b853524f6da4f11900c2022c25e0f98343da1710d84734 again

Thu, Apr 25, 17:25
teamcity added a comment to D16050: [ecash-lib] checksum for ecash-lib-wasm in CI build.
Thu, Apr 25, 17:23
bytesofman updated the diff for D16050: [ecash-lib] checksum for ecash-lib-wasm in CI build.

check if CI hash is 3f42174043db297043b853524f6da4f11900c2022c25e0f98343da1710d84734 again

Thu, Apr 25, 17:21
teamcity added a comment to D16050: [ecash-lib] checksum for ecash-lib-wasm in CI build.
Thu, Apr 25, 17:20
bytesofman updated the diff for D16050: [ecash-lib] checksum for ecash-lib-wasm in CI build.

add debug log to see what checksum is coming from CI

Thu, Apr 25, 17:18
teamcity added a comment to D16050: [ecash-lib] checksum for ecash-lib-wasm in CI build.
Thu, Apr 25, 17:17
bytesofman updated the test plan for D16050: [ecash-lib] checksum for ecash-lib-wasm in CI build.
Thu, Apr 25, 17:16
bytesofman updated the diff for D16050: [ecash-lib] checksum for ecash-lib-wasm in CI build.

update checksum to match local testing

Thu, Apr 25, 17:15
bytesofman planned changes to D16050: [ecash-lib] checksum for ecash-lib-wasm in CI build.

output of ./build-wasm.sh does not appear to be deterministic, though output of dockerbuild.sh does seem to be so

Thu, Apr 25, 17:04
tobias_ruck published D16052: [ecash-lib] Move ecash-lib-wasm back to root workspace for review.
Thu, Apr 25, 16:55
teamcity added a comment to D16050: [ecash-lib] checksum for ecash-lib-wasm in CI build.
Thu, Apr 25, 16:48
bytesofman updated the diff for D16050: [ecash-lib] checksum for ecash-lib-wasm in CI build.

perform checksum confirmation in CI, update README

Thu, Apr 25, 16:43
teamcity awarded D16052: [ecash-lib] Move ecash-lib-wasm back to root workspace a Doubloon token.
Thu, Apr 25, 16:43
tobias_ruck requested changes to D16050: [ecash-lib] checksum for ecash-lib-wasm in CI build.
Thu, Apr 25, 16:33
teamcity awarded D16052: [ecash-lib] Move ecash-lib-wasm back to root workspace a Piece of Eight token.
Thu, Apr 25, 16:29
tobias_ruck requested review of D16053: [ecash-lib] Enable NodeJS support.
Thu, Apr 25, 16:20
teamcity awarded D16052: [ecash-lib] Move ecash-lib-wasm back to root workspace a Haypence token.
Thu, Apr 25, 14:55
teamcity added a comment to D16050: [ecash-lib] checksum for ecash-lib-wasm in CI build.
Thu, Apr 25, 14:11
bytesofman updated the diff for D16050: [ecash-lib] checksum for ecash-lib-wasm in CI build.

add Cargo.lock to gitignore, artifact from running builds locally

Thu, Apr 25, 14:09
bytesofman added a comment to D16050: [ecash-lib] checksum for ecash-lib-wasm in CI build.

./dockerbuild.sh: line 4: docker: command not found

Thu, Apr 25, 13:59
bytesofman closed D16043: [Cashtab] Support minting NFTs.
Thu, Apr 25, 13:46
bytesofman committed rABC9e9999a38f4b: [Cashtab] Support minting NFTs (authored by bytesofman).
[Cashtab] Support minting NFTs
Thu, Apr 25, 13:46
bytesofman added a comment to D16043: [Cashtab] Support minting NFTs.

LGTM.
My only other feedback is to have a back button to navigate from the NFT back to the Collection otherwise it's a whole lot of clicks when viewing each NFT, but that can be done as part of the NFT child implementation.
Also the fan out tx seems to cost around 300-500 XEC each tx, incl fees. Should this be mentioned anywhere in case the user fans out a dozen times and is surprised by the cost. (this is in the context of a few people recently even complaining about the 5.5 XEC fee =) )

Thu, Apr 25, 13:44
teamcity added a comment to D16050: [ecash-lib] checksum for ecash-lib-wasm in CI build.
Thu, Apr 25, 13:42
bytesofman updated the test plan for D16050: [ecash-lib] checksum for ecash-lib-wasm in CI build.
Thu, Apr 25, 13:41
bytesofman updated the diff for D16050: [ecash-lib] checksum for ecash-lib-wasm in CI build.

update script so it fails on checksum mismatch

Thu, Apr 25, 13:40
emack accepted D16043: [Cashtab] Support minting NFTs.

LGTM.
My only other feedback is to have a back button to navigate from the NFT back to the Collection otherwise it's a whole lot of clicks when viewing each NFT, but that can be done as part of the NFT child implementation.
Also the fan out tx seems to cost around 300-500 XEC each tx, incl fees. Should this be mentioned anywhere in case the user fans out a dozen times and is surprised by the cost. (this is in the context of a few people recently even complaining about the 5.5 XEC fee =) )

Thu, Apr 25, 13:31
bytesofman updated the diff for D16043: [Cashtab] Support minting NFTs.

remove debug logging

Thu, Apr 25, 13:19
bytesofman added a comment to D16043: [Cashtab] Support minting NFTs.

After fan out tx, the Mint NFT UI should indicate the total number of NFT mint inputs available. I can see this info is already available on Tx.js, so tracking it here would also be useful.

Thu, Apr 25, 13:17
bytesofman updated the diff for D16043: [Cashtab] Support minting NFTs.

better table to present NFTs with limited size and scrollable overflow, show user number of Nft Mint Inputs available

Thu, Apr 25, 13:11
emack requested changes to D16043: [Cashtab] Support minting NFTs.

After fan out tx, the Mint NFT UI should indicate the total number of NFT mint inputs available. I can see this info is already available on Tx.js, so tracking it here would also be useful.

Thu, Apr 25, 11:52
tobias_ruck closed D16049: [ecash-lib] Add ALP support.
Thu, Apr 25, 07:54
tobias_ruck committed rABC693391e3e5b0: [ecash-lib] Add ALP support (authored by tobias_ruck).
[ecash-lib] Add ALP support
Thu, Apr 25, 07:54
tobias_ruck updated the diff for D13101: [Mitra] Add Intcode integer format.

add missing include

Thu, Apr 25, 07:27
Fabien requested changes to D16050: [ecash-lib] checksum for ecash-lib-wasm in CI build.
Thu, Apr 25, 06:53
Fabien closed D16048: Reduce port range in functional tests.
Thu, Apr 25, 06:29
Fabien committed rABC3b3c5674a35b: Reduce port range in functional tests (authored by Fabien).
Reduce port range in functional tests
Thu, Apr 25, 06:29
bytesofman accepted D16049: [ecash-lib] Add ALP support.
Thu, Apr 25, 02:31
tobias_ruck added inline comments to D16049: [ecash-lib] Add ALP support.
Thu, Apr 25, 00:15
bytesofman added inline comments to D16049: [ecash-lib] Add ALP support.
Thu, Apr 25, 00:00

Wed, Apr 24

tobias_ruck added a comment to D16049: [ecash-lib] Add ALP support.

I think it would be cool to have it in doc/standards—but yeah the link is a permalink, "owned" by ABC (by Koush), through Notion, so it's fine for the forseeable future. When the doc is moved to the monorepo, we should update all the links in the source, which are easy enough to find.

Wed, Apr 24, 23:34
bytesofman added a comment to D16049: [ecash-lib] Add ALP support.

is there a standard source spec for ALP yet? would be nice to have it in the monorepo under doc/standard -- is the notion site an ok permalink?

Wed, Apr 24, 22:19
bytesofman published D16050: [ecash-lib] checksum for ecash-lib-wasm in CI build for review.
Wed, Apr 24, 22:13
tobias_ruck updated the diff for D16049: [ecash-lib] Add ALP support.

fix test (used a old chronik-client build)

Wed, Apr 24, 21:16
teamcity added a comment to D16049: [ecash-lib] Add ALP support.
Wed, Apr 24, 21:04
tobias_ruck requested review of D16049: [ecash-lib] Add ALP support.
Wed, Apr 24, 20:57
PiRK accepted D16048: Reduce port range in functional tests.
Wed, Apr 24, 20:36
bytesofman updated the diff for D16043: [Cashtab] Support minting NFTs.

remove unrelated line break change in useWallet.js

Wed, Apr 24, 19:15
bytesofman added inline comments to D16043: [Cashtab] Support minting NFTs.
Wed, Apr 24, 19:15
bytesofman added inline comments to D16043: [Cashtab] Support minting NFTs.
Wed, Apr 24, 19:13
bytesofman updated the diff for D16043: [Cashtab] Support minting NFTs.

lint

Wed, Apr 24, 19:08
bytesofman updated the diff for D16043: [Cashtab] Support minting NFTs.

patch bug in fan tx output calculation, update related tests, add tests for rendering NFT parent with NFT and NFT, get rid of dedicated component for MintNFT form and use existing one with conditions

Wed, Apr 24, 19:07
tobias_ruck closed D15921: [Chronik] Add LOKAD ID index.
Wed, Apr 24, 16:29
tobias_ruck committed rABC3c106476b316: [Chronik] Add LOKAD ID index (authored by tobias_ruck).
[Chronik] Add LOKAD ID index
Wed, Apr 24, 16:29
tobias_ruck closed D16046: [ecash-lib] Bump integration-tests timeout.
Wed, Apr 24, 16:27
tobias_ruck committed rABCa8aee3304a71: [ecash-lib] Bump integration-tests timeout (authored by tobias_ruck).
[ecash-lib] Bump integration-tests timeout
Wed, Apr 24, 16:27
Fabien published D16048: Reduce port range in functional tests for review.
Wed, Apr 24, 15:50
teamcity awarded D16048: Reduce port range in functional tests a Like token.
Wed, Apr 24, 15:38
teamcity awarded D16048: Reduce port range in functional tests a Mountain of Wealth token.
Wed, Apr 24, 15:19
teamcity awarded D16048: Reduce port range in functional tests a Doubloon token.
Wed, Apr 24, 14:53
teamcity awarded D16048: Reduce port range in functional tests a Piece of Eight token.
Wed, Apr 24, 14:39
teamcity awarded D16048: Reduce port range in functional tests a Haypence token.
Wed, Apr 24, 13:57
emack closed D16047: [Cashtab Extension] Increase height to improve app->extension UX.
Wed, Apr 24, 13:22
emack committed rABC289e2698f0a7: [Cashtab Extension] Increase height to improve app->extension UX (authored by emack).
[Cashtab Extension] Increase height to improve app->extension UX
Wed, Apr 24, 13:22
emack updated the diff for D16047: [Cashtab Extension] Increase height to improve app->extension UX.

version bump

Wed, Apr 24, 13:16
emack added a comment to D16043: [Cashtab] Support minting NFTs.

Per tg chat, here's the trace:

image.png (183×337 px, 21 KB)

hex: 0200000002e6410089e84b4fe22d2baf00b29f1aaf2d45b56a84491fb946aa9fb737d9a2e4010000006b483045022100f1bba9bac4356882f91309fad8ecd7d5303317ad5f7c4345baeee89d6eea222302206f96083beda6b821bcbf164301b2fa390ff3104f1b69d63ce3201d54bc2b0a86412102a607da95600985319cc9009d0970a92161c8b7cd5c8e04ac67e203cd64383600ffffffff34f4135763d899ecaf4a74c349a30d266fd733112178fe1a580a752b22817fa3020000006b483045022100d1879f63ee2974f1edb56335bfd84a67425e1e5b0ca120da02596c31d225ec3102204c175b67bffdfddac5ff66f543fa4315688cf7e962d11c521500d41aa8253dd1412102a607da95600985319cc9009d0970a92161c8b7cd5c8e04ac67e203cd64383600ffffffff150000000000000000d96a04534c500001810453454e4420e4a2d937b79faa46b91f49846ab5452daf1a9fb200af2b2de24f4be8890041e608000000000000000108000000000000000108000000000000000108000000000000000108000000000000000108000000000000000108000000000000000108000000000000000108000000000000000108000000000000000108000000000000000108000000000000000108000000000000000108000000000000000108000000000000000108000000000000000108000000000000000108000000000000000108000000000000005122020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288acb8120000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac00000000

Wed, Apr 24, 13:13
emack updated the diff for D16047: [Cashtab Extension] Increase height to improve app->extension UX.

Move off master branch

Wed, Apr 24, 13:02
bytesofman accepted D16047: [Cashtab Extension] Increase height to improve app->extension UX.

please do a patch version bump in extension/public/manifest.json before landing. Let me know when you land and I will submit to the chrome store.

Wed, Apr 24, 13:01
emack updated the summary of D16047: [Cashtab Extension] Increase height to improve app->extension UX.
Wed, Apr 24, 12:29
emack requested review of D16047: [Cashtab Extension] Increase height to improve app->extension UX.
Wed, Apr 24, 12:26
emack requested changes to D16043: [Cashtab] Support minting NFTs.

image.png (947×1 px, 320 KB)

Wed, Apr 24, 11:32
Fabien closed D16044: [chronik-docs] Trim to version number in installation steps.
Wed, Apr 24, 07:19
Fabien committed rABC2aa757dd2aeb: [chronik-docs] Trim to version number in installation steps (authored by Fabien).
[chronik-docs] Trim to version number in installation steps
Wed, Apr 24, 07:19
bytesofman accepted D16046: [ecash-lib] Bump integration-tests timeout.
Wed, Apr 24, 06:20
tobias_ruck updated the diff for D15921: [Chronik] Add LOKAD ID index.

rerun CI, last one got Error: Chronik failed binding to 127.0.0.1:33962: Address already in use (os error 98)

Wed, Apr 24, 00:58

Tue, Apr 23

bytesofman published D16043: [Cashtab] Support minting NFTs for review.
Tue, Apr 23, 23:14
teamcity added a comment to D15921: [Chronik] Add LOKAD ID index.
Tue, Apr 23, 22:17
tobias_ruck updated the diff for D15921: [Chronik] Add LOKAD ID index.

rebase onto D16046

Tue, Apr 23, 22:01
tobias_ruck requested review of D16046: [ecash-lib] Bump integration-tests timeout.
Tue, Apr 23, 21:52
teamcity added a comment to D15921: [Chronik] Add LOKAD ID index.
Tue, Apr 23, 21:40
tobias_ruck updated the diff for D15921: [Chronik] Add LOKAD ID index.

rebase onto master to fix build?

Tue, Apr 23, 21:24

Panel Used By

Event Timeline

zawagner renamed this panel from to Recent Activity.Apr 18 2018, 03:15
zawagner edited an edge.