Page MenuHomePhabricator
Differential D3716

Give an error and exit if there are unknown parameters
ClosedPublic
Actions

Authored by deadalnix on Jul 23 2019, 12:20.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGc314457a3fdb: Give an error and exit if there are unknown parameters
rABCc314457a3fdb: Give an error and exit if there are unknown parameters
Summary
  • If an unknown option is given via either the command line args or

the conf file, throw an error and exit

Update tests for ArgsManager knowing args

Ignore unknown options in the config file for bitcoin-cli

Fix tests and bitcoin-cli to match actual options used

  • Test gArgs erroring on unknown args
  • Updated linter to reflect the new behavior.

Depends on D3713, D3715 and D3712

This is a backport of Core PR13112

Test Plan
arc lint --everything
make check
test/functional/test_runner.py --extended

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr13112-2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6935
Build 11917: Bitcoin ABC Buildbot (legacy)
Build 11916: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 23 2019, 12:20
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 23 2019, 12:20
teamcity added a comment.Jul 23 2019, 12:20

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix edited the summary of this revision. (Show Details)Jul 23 2019, 12:20
teamcity added a comment.Jul 23 2019, 12:29

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6918: Diff 10399.Jul 23 2019, 12:29
deadalnix added a child revision: D3718: Replace boost program_options.Jul 23 2019, 15:54
deadalnix updated this revision to Diff 10425.Jul 24 2019, 13:10

rebase

teamcity added a comment.Jul 24 2019, 13:10

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jul 24 2019, 13:19

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B6935: Diff 10425.Jul 24 2019, 13:19
Fabien accepted this revision.Jul 24 2019, 15:28
This revision is now accepted and ready to land.Jul 24 2019, 15:28
Closed by commit rABCc314457a3fdb: Give an error and exit if there are unknown parameters (authored by Andrew Chow <achow101-github@achow101.com>, committed by deadalnix). · Explain WhyJul 24 2019, 15:58
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCc314457a3fdb: Give an error and exit if there are unknown parameters.
deadalnix added a commit: rSTAGINGc314457a3fdb: Give an error and exit if there are unknown parameters.Sep 19 2019, 01:24
Fabien mentioned this in D5054: Prevent shared conf files from failing with different available options in different binaries.Jan 27 2020, 08:45

Revision Contents
Changeset List

PathSize
src/
bench/
11 lines
23 lines
11 lines
14 lines
20 lines
interfaces/
5 lines
9 lines
qt/
44 lines
rpc/
test/
11 lines
test/
15 lines
67 lines
18 lines
61 lines
test/
functional/
13 lines
lint/
23 lines

Diff 10425

View Options

src/bench/bench_bitcoin.cpp

Loading...
View Options

src/bitcoin-cli.cpp

Loading...
View Options

src/bitcoin-tx.cpp

Loading...
View Options

src/bitcoind.cpp

Loading...
View Options

src/init.cpp

Loading...
View Options

src/interfaces/node.h

Loading...
View Options

src/interfaces/node.cpp

Loading...
View Options

src/qt/bitcoin.cpp

Loading...
View Options

src/rpc/test/server_tests.cpp

Loading...
View Options

src/test/getarg_tests.cpp

Loading...
View Options

src/test/util_tests.cpp

Loading...
View Options

src/util.h

Loading...
View Options

src/util.cpp

Loading...
View Options

test/functional/feature_help.py

Loading...
View Options

test/lint/check-doc.py

Loading...