Paths

Table of Contentst

Merge #13916: qa: wait_for_verack by default
ClosedPublic
Actions

Authored by jasonbcox on Sep 6 2019, 22:46.

Details

Reviewers

deadalnix
Fabien

Group Reviewers

Restricted Project

Commits

rSTAGINGbb86d8de9a17: Merge #13916: qa: wait_for_verack by default
rABCbb86d8de9a17: Merge #13916: qa: wait_for_verack by default

Summary

fa5587fe71 qa: wait_for_verack by default (MarcoFalke)

Pull request description:

This removes the need to do so manually every time a connection is added.

Tree-SHA512: a46c92cb4df41e30778b42b9fd3dcbd8d2d82aa7503d1213cb1c1165034f648d8caee01c292e2d87d05b0f71696996eef5be8a753f35ab49e5f66b0e3bf29f21

Backport of Core PR13916
https://github.com/bitcoin/bitcoin/pull/13916/files
Completes T684

Test Plan

test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jasonbcox created this revision.Sep 6 2019, 22:46

Herald added a reviewer: deadalnix. · View Herald TranscriptSep 6 2019, 22:46

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7359: Diff 11149.Sep 6 2019, 22:54

Fabien accepted this revision.Sep 9 2019, 09:19

This revision is now accepted and ready to land.Sep 9 2019, 09:19

Closed by commit rABCbb86d8de9a17: Merge #13916: qa: wait_for_verack by default (authored by MarcoFalke <falke.marco@gmail.com>, committed by jasonbcox). · Explain WhySep 9 2019, 16:20

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rABCbb86d8de9a17: Merge #13916: qa: wait_for_verack by default.

jasonbcox added a commit: rSTAGINGbb86d8de9a17: Merge #13916: qa: wait_for_verack by default.Sep 19 2019, 02:12

Revision Contents
Changeset List

Path

Size

test/

functional/

abc-invalid-chains.py

1 line

abc-invalid-message.py

7 lines

abc-mempool-accept-txn.py

1 line

abc-mempool-coherence-on-activations.py

1 line

abc-minimaldata-activation.py

1 line

abc-p2p-compactblocks.py

2 lines

abc-p2p-fullblocktest.py

2 lines

abc-replay-protection.py

1 line

abc-schnorr.py

1 line

abc-schnorrmultisig-activation.py

1 line

abc-segwit-recovery.py

2 lines

abc-sync-chain.py

1 line

abc-transaction-ordering.py

1 line

example_test.py

6 lines

feature_assumevalid.py

7 lines

feature_cltv.py

1 line

feature_csv_activation.py

1 line

feature_dersig.py

3 lines

feature_maxuploadtarget.py

6 lines

2 lines

2 lines

1 line

1 line

1 line

4 lines

4 lines

1 line

p2p_node_network_limited.py

2 lines

p2p_sendheaders.py

2 lines

p2p_timeouts.py

4 lines

p2p_unrequested_blocks.py

4 lines

rpc_blockchain.py

4 lines

test_framework/

test_node.py

6 lines

Diff 11161

View Options

test/functional/abc-invalid-chains.py

View Options

test/functional/abc-invalid-message.py

View Options

test/functional/abc-mempool-accept-txn.py

View Options

test/functional/abc-mempool-coherence-on-activations.py

View Options

test/functional/abc-minimaldata-activation.py

View Options

test/functional/abc-p2p-compactblocks.py

View Options

test/functional/abc-p2p-fullblocktest.py

View Options

test/functional/abc-replay-protection.py

View Options

test/functional/abc-schnorr.py

View Options

test/functional/abc-schnorrmultisig-activation.py

View Options

test/functional/abc-segwit-recovery.py

View Options

test/functional/abc-sync-chain.py

View Options

test/functional/abc-transaction-ordering.py

View Options

test/functional/example_test.py

View Options

test/functional/feature_assumevalid.py

View Options

test/functional/feature_cltv.py

View Options

test/functional/feature_csv_activation.py

View Options

test/functional/feature_dersig.py

View Options

test/functional/feature_maxuploadtarget.py

View Options

test/functional/p2p_compactblocks.py

View Options

test/functional/p2p_feefilter.py

View Options

test/functional/p2p_fingerprint.py

View Options

test/functional/p2p_invalid_block.py

View Options

test/functional/p2p_invalid_tx.py

View Options

test/functional/p2p_leak.py

View Options

test/functional/p2p_leak_tx.py

View Options

test/functional/p2p_mempool.py

View Options

test/functional/p2p_node_network_limited.py

View Options

test/functional/p2p_sendheaders.py

View Options

test/functional/p2p_timeouts.py

View Options

test/functional/p2p_unrequested_blocks.py

View Options

test/functional/rpc_blockchain.py

View Options

test/functional/test_framework/test_node.py

Merge #13916: qa: wait_for_verack by defaultClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 11161

test/functional/abc-invalid-chains.py

test/functional/abc-invalid-message.py

test/functional/abc-mempool-accept-txn.py

test/functional/abc-mempool-coherence-on-activations.py

test/functional/abc-minimaldata-activation.py

test/functional/abc-p2p-compactblocks.py

test/functional/abc-p2p-fullblocktest.py

test/functional/abc-replay-protection.py

test/functional/abc-schnorr.py

test/functional/abc-schnorrmultisig-activation.py

test/functional/abc-segwit-recovery.py

test/functional/abc-sync-chain.py

test/functional/abc-transaction-ordering.py

test/functional/example_test.py

test/functional/feature_assumevalid.py

test/functional/feature_cltv.py

test/functional/feature_csv_activation.py

test/functional/feature_dersig.py

test/functional/feature_maxuploadtarget.py

test/functional/p2p_compactblocks.py

test/functional/p2p_feefilter.py

test/functional/p2p_fingerprint.py

test/functional/p2p_invalid_block.py

test/functional/p2p_invalid_tx.py

test/functional/p2p_leak.py

test/functional/p2p_leak_tx.py

test/functional/p2p_mempool.py

test/functional/p2p_node_network_limited.py

test/functional/p2p_sendheaders.py

test/functional/p2p_timeouts.py

test/functional/p2p_unrequested_blocks.py

test/functional/rpc_blockchain.py

test/functional/test_framework/test_node.py

Merge #13916: qa: wait_for_verack by default
ClosedPublic
Actions

Revision Contents
Changeset List