Page MenuHomePhabricator
Differential D4048

Source the Excessive block size from BlockValidationOptions
ClosedPublic
Actions

Authored by deadalnix on Sep 12 2019, 05:55.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGee8d40aec77e: Source the Excessive block size from BlockValidationOptions
rABCee8d40aec77e: Source the Excessive block size from BlockValidationOptions
Summary

After all, it's a block validation option.

Test Plan
make check
./test/functional/test_runner.py --extended

Diff Detail

Repository
rABC Bitcoin ABC
Branch
BlockValidationOptionsExcessiveBlockSize
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7411
Build 12865: Bitcoin ABC Buildbot (legacy)
Build 12864: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 12 2019, 05:55
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 12 2019, 05:55
teamcity added a comment.Sep 12 2019, 05:55

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 12 2019, 06:03

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7409: Diff 11230.Sep 12 2019, 06:03
deadalnix added a child revision: D4049: Remove CheckBlock's dependency on Config.Sep 12 2019, 06:58
Fabien requested changes to this revision.Sep 12 2019, 07:07
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/bench/checkblock.cpp
53 ↗(On Diff #11230)

It can be constructed once outside of the loop.

src/validation.h
592 ↗(On Diff #11230)

BlockValidationOptions can be passed as const.

611 ↗(On Diff #11230)

Dito.

This revision now requires changes to proceed.Sep 12 2019, 07:07
deadalnix added inline comments.Sep 12 2019, 07:27
src/validation.h
592 ↗(On Diff #11230)

It's immutable by design.

611 ↗(On Diff #11230)

dito

deadalnix updated this revision to Diff 11232.Sep 12 2019, 07:31

Build outside the loop

teamcity added a comment.Sep 12 2019, 07:31

Build Bitcoin-ABC / Diffs / Diff Testing started.

Fabien accepted this revision.Sep 12 2019, 07:33
This revision is now accepted and ready to land.Sep 12 2019, 07:33
teamcity added a comment.Sep 12 2019, 07:38

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7411: Diff 11232.Sep 12 2019, 07:38
Closed by commit rABCee8d40aec77e: Source the Excessive block size from BlockValidationOptions (authored by deadalnix). · Explain WhySep 12 2019, 08:16
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCee8d40aec77e: Source the Excessive block size from BlockValidationOptions.
deadalnix added a commit: rSTAGINGee8d40aec77e: Source the Excessive block size from BlockValidationOptions.Sep 19 2019, 02:16

Revision Contents
Changeset List

PathSize
src/
bench/
4 lines
2 lines
5 lines
rpc/
6 lines
test/
7 lines
33 lines
30 lines

Diff 11232

View Options

src/bench/checkblock.cpp

Loading...
View Options

src/blockencodings.cpp

Loading...
View Options

src/miner.cpp

Loading...
View Options

src/rpc/mining.cpp

Loading...
View Options

src/test/blockcheck_tests.cpp

Loading...
View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...