Page MenuHomePhabricator

Remove CheckBlockHeader's dependency on Config

Authored by deadalnix on Sep 11 2019, 16:57.



As per title.

Test Plan
make check

Diff Detail

rABC Bitcoin ABC
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Sep 11 2019, 16:57
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 11 2019, 16:57
jasonbcox requested changes to this revision.Sep 11 2019, 17:50
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
3443 ↗(On Diff #11206)

To match Core, params should be moved after state.

This revision now requires changes to proceed.Sep 11 2019, 17:50
jasonbcox added inline comments.Sep 11 2019, 17:53
3443 ↗(On Diff #11206)

Also use their naming consensusParams instead of params.

deadalnix updated this revision to Diff 11235.Sep 12 2019, 09:09

Rebase, fix merge conflicts and change parameter order

jasonbcox accepted this revision.Sep 12 2019, 15:35
This revision is now accepted and ready to land.Sep 12 2019, 15:35
This revision was automatically updated to reflect the committed changes.