Page MenuHomePhabricator

Remove CheckBlockHeader's dependency on Config
ClosedPublic

Authored by deadalnix on Wed, Sep 11, 16:57.

Details

Summary

As per title.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Wed, Sep 11, 16:57
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Sep 11, 16:57
jasonbcox requested changes to this revision.Wed, Sep 11, 17:50
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/validation.cpp
3443 ↗(On Diff #11206)

To match Core, params should be moved after state.

This revision now requires changes to proceed.Wed, Sep 11, 17:50
jasonbcox added inline comments.Wed, Sep 11, 17:53
src/validation.cpp
3443 ↗(On Diff #11206)

Also use their naming consensusParams instead of params.

deadalnix updated this revision to Diff 11235.Thu, Sep 12, 09:09

Rebase, fix merge conflicts and change parameter order

jasonbcox accepted this revision.Thu, Sep 12, 15:35
This revision is now accepted and ready to land.Thu, Sep 12, 15:35
This revision was automatically updated to reflect the committed changes.