Page MenuHomePhabricator
Differential D4040

Remove CheckBlockHeader's dependency on Config
ClosedPublic
Actions

Authored by deadalnix on Sep 11 2019, 16:57.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING3cf5f7776d4a: Remove CheckBlockHeader's dependency on Config
rABC3cf5f7776d4a: Remove CheckBlockHeader's dependency on Config
Summary

As per title.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
CheckBlockHeaderconsensus
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7412
Build 12867: Bitcoin ABC Buildbot (legacy)
Build 12866: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 11 2019, 16:57
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 11 2019, 16:57
teamcity added a comment.Sep 11 2019, 16:57

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 11 2019, 17:06

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7393: Diff 11206.Sep 11 2019, 17:06
jasonbcox requested changes to this revision.Sep 11 2019, 17:50
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/validation.cpp
3443 ↗(On Diff #11206)

To match Core, params should be moved after state.

This revision now requires changes to proceed.Sep 11 2019, 17:50
jasonbcox added inline comments.Sep 11 2019, 17:53
src/validation.cpp
3443 ↗(On Diff #11206)

Also use their naming consensusParams instead of params.

deadalnix added a child revision: D4049: Remove CheckBlock's dependency on Config.Sep 12 2019, 06:58
deadalnix updated this revision to Diff 11235.Sep 12 2019, 09:09

Rebase, fix merge conflicts and change parameter order

teamcity added a comment.Sep 12 2019, 09:09

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 12 2019, 09:16

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7412: Diff 11235.Sep 12 2019, 09:16
jasonbcox accepted this revision.Sep 12 2019, 15:35
This revision is now accepted and ready to land.Sep 12 2019, 15:35
Closed by commit rABC3cf5f7776d4a: Remove CheckBlockHeader's dependency on Config (authored by deadalnix). · Explain WhySep 12 2019, 16:16
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC3cf5f7776d4a: Remove CheckBlockHeader's dependency on Config.
deadalnix added a commit: rSTAGING3cf5f7776d4a: Remove CheckBlockHeader's dependency on Config.Sep 19 2019, 02:16

Revision Contents
Changeset List

PathSize
src/
12 lines

Diff 11235

View Options

src/validation.cpp

Loading...