Page MenuHomePhabricator

Source the Excessive block size from BlockValidationOptions
ClosedPublic

Authored by deadalnix on Thu, Sep 12, 05:55.

Details

Summary

After all, it's a block validation option.

Test Plan
make check
./test/functional/test_runner.py --extended

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Thu, Sep 12, 05:55
Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Sep 12, 05:55
Fabien requested changes to this revision.Thu, Sep 12, 07:07
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/bench/checkblock.cpp
53 ↗(On Diff #11230)

It can be constructed once outside of the loop.

src/validation.h
592 ↗(On Diff #11230)

BlockValidationOptions can be passed as const.

611 ↗(On Diff #11230)

Dito.

This revision now requires changes to proceed.Thu, Sep 12, 07:07
deadalnix added inline comments.Thu, Sep 12, 07:27
src/validation.h
592 ↗(On Diff #11230)

It's immutable by design.

611 ↗(On Diff #11230)

dito

deadalnix updated this revision to Diff 11232.Thu, Sep 12, 07:31

Build outside the loop

Fabien accepted this revision.Thu, Sep 12, 07:33
This revision is now accepted and ready to land.Thu, Sep 12, 07:33