Page MenuHomePhabricator
Differential D4049

Remove CheckBlock's dependency on Config
ClosedPublic
Actions

Authored by deadalnix on Sep 12 2019, 06:58.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING609737372479: Remove CheckBlock's dependency on Config
rABC609737372479: Remove CheckBlock's dependency on Config
Summary

As per title.

Depends on D4040 and D4048

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
CheckBlockconsensus
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7425
Build 12893: Bitcoin ABC Buildbot (legacy)
Build 12892: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 12 2019, 06:58
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 12 2019, 06:58
teamcity added a comment.Sep 12 2019, 06:58

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B7410: Diff 11231.Sep 12 2019, 07:07
teamcity added a comment.Sep 12 2019, 07:07

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Fabien added a subscriber: Fabien.Sep 12 2019, 07:24
Fabien added inline comments.
src/validation.h
590 ↗(On Diff #11231)

If you move params after the state you will reduce the merge conflicts with core.

deadalnix updated this revision to Diff 11236.Sep 12 2019, 09:18

Rebase and change parameter order

teamcity added a comment.Sep 12 2019, 09:18

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 12 2019, 09:27

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7413: Diff 11236.Sep 12 2019, 09:27
deadalnix added a child revision: D4050: Remove ConnectBlock's dependency on Config.Sep 12 2019, 10:31
deadalnix updated this revision to Diff 11250.Sep 12 2019, 16:27

Rebase, fix merge conflicts

teamcity added a comment.Sep 12 2019, 16:27

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 12 2019, 16:39

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7425: Diff 11250.Sep 12 2019, 16:39
Fabien accepted this revision.Sep 12 2019, 18:11
This revision is now accepted and ready to land.Sep 12 2019, 18:11
Closed by commit rABC609737372479: Remove CheckBlock's dependency on Config (authored by deadalnix). · Explain WhySep 13 2019, 06:18
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC609737372479: Remove CheckBlock's dependency on Config.
deadalnix added a commit: rSTAGING609737372479: Remove CheckBlock's dependency on Config.Sep 19 2019, 02:19

Revision Contents
Changeset List

PathSize
src/
bench/
4 lines
3 lines
test/
2 lines
4 lines
27 lines

Diff 11250

View Options

src/bench/checkblock.cpp

Loading...
View Options

src/blockencodings.cpp

Loading...
View Options

src/test/blockcheck_tests.cpp

Loading...
View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...