Remove GetNextBlockScriptFlags's requirement to hold cs_main
ClosedPublic
Actions

Authored by deadalnix on Sep 17 2019, 13:28.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGfbe5b35601f6: Remove GetNextBlockScriptFlags's requirement to hold cs_main
rABCfbe5b35601f6: Remove GetNextBlockScriptFlags's requirement to hold cs_main

Summary

It turns out this is not needed.

Test Plan

Build with clang, check there's no warning.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

cs_mainflags

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7491
Build 13025: Bitcoin ABC Buildbot (legacy)
Build 13024: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 17 2019, 13:28

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 17 2019, 13:28

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7491: Diff 11363.Sep 17 2019, 13:45

Fabien accepted this revision.Sep 17 2019, 13:57

This revision is now accepted and ready to land.Sep 17 2019, 13:57

Closed by commit rABCfbe5b35601f6: Remove GetNextBlockScriptFlags's requirement to hold cs_main (authored by deadalnix). · Explain WhySep 17 2019, 14:47

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCfbe5b35601f6: Remove GetNextBlockScriptFlags's requirement to hold cs_main.

deadalnix added a commit: rSTAGINGfbe5b35601f6: Remove GetNextBlockScriptFlags's requirement to hold cs_main.Sep 19 2019, 02:24

PiRK mentioned this in D12219: versionbits: Use dedicated lock instead of cs_main.Oct 12 2022, 12:46

PiRK mentioned this in rABC69c9129eb3ee: versionbits: Use dedicated lock instead of cs_main.Oct 13 2022, 09:11

Revision Contents
Changeset List

Path

Size

src/

validation.cpp

7 lines

Diff 11363

View Options

Remove GetNextBlockScriptFlags's requirement to hold cs_mainClosedPublicActions