Paths

Table of Contentst

[CMAKE] Add the check-security target
ClosedPublic
Actions

Authored by Fabien on Sep 23 2019, 13:00.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGING4dab36ebb168: [CMAKE] Add the check-security target
rABC4dab36ebb168: [CMAKE] Add the check-security target

Summary

This target runs the security-check.py scripts on the executables.
This is the equivalent of the autotools check-security rule.

Depends on D4136.

Test Plan

Build the depends subsystem for linux 64, then:

mkdir buildcmake && cd buildcmake
cmake -GNinja .. \
  -DENABLE_GLIBC_BACK_COMPAT=ON \
  -DENABLE_STATIC_LIBSTDCXX=ON \
  -DENABLE_REDUCE_EXPORTS=ON \
  -DCMAKE_TOOLCHAIN_FILE=../cmake/platforms/Linux64.cmake
ninja check-security

If should be successful.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

cmake_check_security

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7553
Build 13146: Bitcoin ABC Buildbot (legacy)
Build 13145: arc lint + arc unit

Event Timeline

Fabien created this revision.Sep 23 2019, 13:00

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 23 2019, 13:00

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7553: Diff 13084.Sep 23 2019, 13:10

jasonbcox accepted this revision.Sep 23 2019, 23:56

This revision is now accepted and ready to land.Sep 23 2019, 23:56

Fabien planned changes to this revision.Sep 24 2019, 08:26

Rebase and don't run security checks on target which are not intended to be installed.

This revision is now accepted and ready to land.Sep 24 2019, 09:58

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B7568: Diff 13108.Sep 24 2019, 10:14

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Closed by commit rABC4dab36ebb168: [CMAKE] Add the check-security target (authored by Fabien). · Explain WhySep 25 2019, 18:48

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC4dab36ebb168: [CMAKE] Add the check-security target.

Fabien added a commit: rSTAGING4dab36ebb168: [CMAKE] Add the check-security target.Sep 27 2019, 22:49

Revision Contents
Changeset List

Path

Size

CMakeLists.txt

4 lines

cmake/

modules/

BinaryTest.cmake

17 lines

src/

CMakeLists.txt

3 lines

bench/

CMakeLists.txt

1 line

qt/

CMakeLists.txt

1 line

test/

CMakeLists.txt

1 line

seeder/

CMakeLists.txt

1 line

test/

CMakeLists.txt

1 line

Diff 13084

View Options

CMakeLists.txt

View Options

cmake/modules/BinaryTest.cmake

View Options

src/CMakeLists.txt

View Options

src/bench/CMakeLists.txt

View Options

src/qt/CMakeLists.txt

View Options

src/qt/test/CMakeLists.txt

View Options

src/seeder/CMakeLists.txt

View Options

[CMAKE] Add the check-security targetClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 13084

CMakeLists.txt

cmake/modules/BinaryTest.cmake

src/CMakeLists.txt

src/bench/CMakeLists.txt

src/qt/CMakeLists.txt

src/qt/test/CMakeLists.txt

src/seeder/CMakeLists.txt

src/test/CMakeLists.txt

[CMAKE] Add the check-security target
ClosedPublic
Actions

Revision Contents
Changeset List