Page MenuHomePhabricator
Differential D4142

Remove redundant variables, statements and forward declarations
ClosedPublic
Actions

Authored by fpelliccioni on Sep 23 2019, 21:47.

Details

Reviewers
Fabien
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING46b2cbc8507b: Remove redundant variables, statements and forward declarations
rABC46b2cbc8507b: Remove redundant variables, statements and forward declarations
Summary

Remove redundant …

  • ~access modifiers,~
  • forward declarations,
  • unused variables,
  • statements, and
  • ~return types from lambdas.~

Backport of Bitcoin Core PR13691
https://github.com/bitcoin/bitcoin/pull/13691

Test Plan
make check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
feature-backport-62baa2878
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7560
Build 13160: Bitcoin ABC Buildbot (legacy)
Build 13159: arc lint + arc unit

Event Timeline

fpelliccioni created this revision.Sep 23 2019, 21:47
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 23 2019, 21:47
Herald added a reviewer: deadalnix. · View Herald Transcript
jasonbcox requested changes to this revision.Sep 23 2019, 21:52
jasonbcox added a subscriber: jasonbcox.

Can you clarify if the other instances are missing or all of them are already applied to the codebase?

This revision now requires changes to proceed.Sep 23 2019, 21:52
teamcity added a comment.Sep 23 2019, 22:00

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 23 2019, 22:10

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7560: Diff 13097.Sep 23 2019, 22:10
fpelliccioni added a comment.Sep 24 2019, 12:47
In D4142#99061, @jasonbcox wrote:

Can you clarify if the other instances are missing or all of them are already applied to the codebase?

Sorry, what do you mean by "instances"?
The other changes of the PR have already been applied but have not been correctly tagged in your repo.

jasonbcox accepted this revision.Sep 24 2019, 17:58
This revision is now accepted and ready to land.Sep 24 2019, 17:58
Closed by commit rABC46b2cbc8507b: Remove redundant variables, statements and forward declarations (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by fpelliccioni). · Explain WhySep 24 2019, 18:11
This revision was automatically updated to reflect the committed changes.
fpelliccioni added a commit: rABC46b2cbc8507b: Remove redundant variables, statements and forward declarations.
fpelliccioni added a commit: rSTAGING46b2cbc8507b: Remove redundant variables, statements and forward declarations.Sep 27 2019, 22:48

Revision Contents
Changeset List

PathSize
src/
qt/
2 lines

Diff 13097

View Options

src/qt/clientmodel.cpp

Loading...