Page MenuHomePhabricator
Differential D4253

rpc: Add unloadwallet RPC, release notes, and tests
ClosedPublic
Actions

Authored by nakihito on Oct 15 2019, 02:24.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING05f446d4fa29: rpc: Add unloadwallet RPC, release notes, and tests
rABC05f446d4fa29: rpc: Add unloadwallet RPC, release notes, and tests
Summary

This adds the unloadwallet RPC, release notes, and tests for it.

Partial backport of Core PR13111
https://github.com/bitcoin/bitcoin/pull/13111/commits/6608c369b1a6cfc1d5b4a7905c193baa999ba84c
https://github.com/bitcoin/bitcoin/pull/13111/commits/9f9b50d5feb1e604283c463e289e83b63a849a8c
https://github.com/bitcoin/bitcoin/pull/13111/commits/4940a20a46685cd56ea045d8cc7fe058c6222431
https://github.com/bitcoin/bitcoin/pull/13111/commits/ccbf7ae7496fd13b4147aa13d7408712bd90c614
https://github.com/bitcoin/bitcoin/pull/13111/commits/0b82bac76d0f842bd2294a290388536951fbc576 (only the additional test added to wallet_multiwallet.py is taken from here).

Depends on D4252

Note to reviewers: This RPC has a bug discussed here https://github.com/bitcoin/bitcoin/pull/14941

Test Plan
make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR13111-2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7770
Build 13579: Bitcoin ABC Buildbot (legacy)
Build 13578: arc lint + arc unit

Event Timeline

nakihito created this revision.Oct 15 2019, 02:24
Owners added a reviewer: Restricted Owners Package.Oct 15 2019, 02:24
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 15 2019, 02:24
nakihito planned changes to this revision.Oct 15 2019, 02:24
teamcity added a comment.Oct 15 2019, 02:24

Build Bitcoin-ABC / Diffs / Diff Testing started.

nakihito added a child revision: D4254: ui: Support wallets unloaded dynamically.Oct 15 2019, 02:26
Harbormaster completed remote builds in B7770: Diff 13554.Oct 15 2019, 02:37
teamcity added a comment.Oct 15 2019, 02:37

Build Bitcoin-ABC / Diffs / Diff Testing passed.

nakihito requested review of this revision.Oct 15 2019, 02:55
nakihito added inline comments.
doc/release-notes.md
11

Rewording of this commit: https://github.com/bitcoin/bitcoin/pull/13111/commits/9f9b50d5feb1e604283c463e289e83b63a849a8c

src/wallet/rpcwallet.cpp
103

This change is from https://github.com/bitcoin/bitcoin/pull/13111/commits/ccbf7ae7496fd13b4147aa13d7408712bd90c614#diff-df7d84ff2f53fcb2a0dc15a3a51e55ceL82

3360

This change is from here: https://github.com/bitcoin/bitcoin/pull/13111/commits/6608c369b1a6cfc1d5b4a7905c193baa999ba84c#diff-df7d84ff2f53fcb2a0dc15a3a51e55ceL3079

3427

This change is from here: https://github.com/bitcoin/bitcoin/pull/13111/commits/6608c369b1a6cfc1d5b4a7905c193baa999ba84c#diff-df7d84ff2f53fcb2a0dc15a3a51e55ceR3126

3535

This change starts here: https://github.com/bitcoin/bitcoin/pull/13111/commits/6608c369b1a6cfc1d5b4a7905c193baa999ba84c#diff-df7d84ff2f53fcb2a0dc15a3a51e55ceR3173

4628

This change is from here: https://github.com/bitcoin/bitcoin/pull/13111/commits/6608c369b1a6cfc1d5b4a7905c193baa999ba84c#diff-df7d84ff2f53fcb2a0dc15a3a51e55ceR4457

src/wallet/wallet.cpp
98

This change is from here: https://github.com/bitcoin/bitcoin/pull/13111/commits/6608c369b1a6cfc1d5b4a7905c193baa999ba84c#diff-b2bb174788c7409b671c46ccc86034bdR82

1380

This change is from here: https://github.com/bitcoin/bitcoin/pull/13111/commits/6608c369b1a6cfc1d5b4a7905c193baa999ba84c#diff-b2bb174788c7409b671c46ccc86034bdR1306

4380

This change is from here: https://github.com/bitcoin/bitcoin/pull/13111/commits/6608c369b1a6cfc1d5b4a7905c193baa999ba84c#diff-b2bb174788c7409b671c46ccc86034bdR4071

src/wallet/wallet.h
1229

This change is from here: https://github.com/bitcoin/bitcoin/pull/13111/commits/6608c369b1a6cfc1d5b4a7905c193baa999ba84c#diff-12635a58447c65585f51d32b7e04075bR1102

test/functional/wallet_multiwallet.py
277

Tests from this commit: https://github.com/bitcoin/bitcoin/pull/13111/commits/4940a20a46685cd56ea045d8cc7fe058c6222431

279

This test if from https://github.com/bitcoin/bitcoin/pull/13111/commits/ccbf7ae7496fd13b4147aa13d7408712bd90c614#diff-0fed0e6381a6e53f840b3630e5932d13R257

284

These four lines are from https://github.com/bitcoin/bitcoin/pull/13111/commits/0b82bac76d0f842bd2294a290388536951fbc576#diff-0fed0e6381a6e53f840b3630e5932d13R263

nakihito edited the summary of this revision. (Show Details)Oct 15 2019, 03:16
jasonbcox accepted this revision.Oct 16 2019, 20:15

I don't see a good reason to block this based on the discussion in PR14941. That change is an improvement, but we'll need to backport up to it to get it.

This revision is now accepted and ready to land.Oct 16 2019, 20:15
Closed by commit rABC05f446d4fa29: rpc: Add unloadwallet RPC, release notes, and tests (authored by João Barbosa <joao.paulo.barbosa@gmail.com>, committed by nakihito). · Explain WhyOct 19 2019, 02:20
This revision was automatically updated to reflect the committed changes.
Nico Guiton <nico@bitframe.org> added a commit: rABC05f446d4fa29: rpc: Add unloadwallet RPC, release notes, and tests.
nakihito added a commit: rSTAGING05f446d4fa29: rpc: Add unloadwallet RPC, release notes, and tests.Apr 7 2020, 21:27

Revision Contents
Changeset List

PathSize
doc/
2 lines
src/
wallet/
64 lines
3 lines
20 lines
test/
functional/
32 lines

Diff 13554

View Options

doc/release-notes.md

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...
View Options

test/functional/wallet_multiwallet.py

Loading...