Differential D4225
Merge #14444: Add compile time checking for cs_main locks which we assert at run time Authored by nakihito on Oct 7 2019, 23:51. Tags None Subscribers None
Details
0089905361 Add compile time checking for cs_main locks which we assert at run time (practicalswift) Pull request description: Assert locking requirements at compile-time (`EXCLUSIVE_LOCKS_REQUIRED(foo)`) instead of at run-time (`AssertLockHeld(…)`). Tree-SHA512: f4965ebf4bb5dbf5e7ed738cacf82c0f6cd55134fb968860bf84a84e29806485617f223910bb8c5461213f1829b0137c64ba1f6d6a2008b3cac3bb3a28df9324 Backport of Core PR14444 ../configure CXX=clang++ CC=clang make check Run teamcity build-werror
Diff Detail
Event TimelineComment Actions The two lines changes were included in D4026. Edited summary to better clarify. Comment Actions Why is that split this way? s there a reason this patch cannot be done by itself as it is in the PR? Simple patches will help you get faster review. Moving code from a small patch to a large one is usually a losing strategy. In this case, now, you end up having to explain why thing are splet the way they are, which really isn't obvious. |