Page MenuHomePhabricator
Differential D4270

Merge #13248: [gui] Make proxy icon from statusbar clickable
ClosedPublic
Actions

Authored by nakihito on Oct 19 2019, 04:47.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING2d293e74c99d: Merge #13248: [gui] Make proxy icon from statusbar clickable
rABC2d293e74c99d: Merge #13248: [gui] Make proxy icon from statusbar clickable
Summary

6d5fcad576962e5950641f7e7b113a6ac6f397e5 [gui] Make proxy icon from statusbar clickable (Cristian Mircea Messel)

Pull request description:

Clicking on the proxy icon will open settings showing the network tab

https://github.com/bitcoin/bitcoin/pull/11491#issuecomment-336685303

Tree-SHA512: c3549749296918818694a371326d1a3b1075478918aaee940b5c7119a7e2cb991dcfda78f20d44d6d001157b9b82951f0d5157b17f4f0d1a0a242795efade036

Backport of Core PR13248
https://github.com/bitcoin/bitcoin/pull/13248/

Depends on D4269

Test Plan
make check
./bitcoin-qt -proxy=<valid proxy>

Clicking the P icon in the bottom right corner should open up the network tab in the options menu.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR13248
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7817
Build 13656: Bitcoin ABC Buildbot (legacy)
Build 13655: arc lint + arc unit

Event Timeline

nakihito created this revision.Oct 19 2019, 04:47
Owners added a reviewer: Restricted Owners Package.Oct 19 2019, 04:47
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 19 2019, 04:47
nakihito planned changes to this revision.Oct 19 2019, 04:47
teamcity added a comment.Oct 19 2019, 04:47

Build Bitcoin-ABC / Diffs / Diff Testing started.

nakihito requested review of this revision.Oct 19 2019, 04:48
Harbormaster completed remote builds in B7817: Diff 13620.Oct 19 2019, 04:57
teamcity added a comment.Oct 19 2019, 04:57

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Fabien requested changes to this revision.Oct 21 2019, 06:32
Fabien added inline comments.
src/qt/bitcoingui.cpp
858

Braces

src/qt/optionsdialog.cpp
178

Braces, also the next line.

This revision now requires changes to proceed.Oct 21 2019, 06:32
nakihito updated this revision to Diff 13626.Oct 21 2019, 17:36

Added braces.

teamcity added a comment.Oct 21 2019, 17:37

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B7822: Diff 13626.Oct 21 2019, 17:46
teamcity added a comment.Oct 21 2019, 17:46

Build Bitcoin-ABC / Diffs / Diff Testing passed.

deadalnix accepted this revision.Oct 23 2019, 01:29
Fabien accepted this revision.Oct 23 2019, 10:49
This revision is now accepted and ready to land.Oct 23 2019, 10:49
Closed by commit rABC2d293e74c99d: Merge #13248: [gui] Make proxy icon from statusbar clickable (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by nakihito). · Explain WhyOct 23 2019, 19:10
This revision was automatically updated to reflect the committed changes.
Nico Guiton <nico@bitframe.org> added a commit: rABC2d293e74c99d: Merge #13248: [gui] Make proxy icon from statusbar clickable.
nakihito added a commit: rSTAGING2d293e74c99d: Merge #13248: [gui] Make proxy icon from statusbar clickable.Apr 7 2020, 21:29

Revision Contents
Changeset List

PathSize
src/
qt/
16 lines
27 lines
6 lines
9 lines

Diff 13620

View Options

src/qt/bitcoingui.h

Loading...
View Options

src/qt/bitcoingui.cpp

Loading...
View Options

src/qt/optionsdialog.h

Loading...
View Options

src/qt/optionsdialog.cpp

Loading...