Page MenuHomePhabricator
Differential D4269

Merge #11491: [gui] Add proxy icon in statusbar
ClosedPublic
Actions

Authored by nakihito on Oct 19 2019, 04:29.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGbc8ad5ec1d81: Merge #11491: [gui] Add proxy icon in statusbar
rABCbc8ad5ec1d81: Merge #11491: [gui] Add proxy icon in statusbar
Summary

73cd5b25b [gui] Add proxy icon in statusbar (Cristian Mircea Messel)

Pull request description:

Relates to #7734

![image](https://user-images.githubusercontent.com/226170/33406640-8ea700c6-d576-11e7-9d69-fde9a696c219.png)

Please ignore the wrong alpha in the screenshot, I couldn't get the screenshot alpha right :(

I plan to extend this feature in future PRs to include:

- custom Tor icon
- clickable icon which opens network settings

Old proposals, dropped in favor of current

![image](https://user-images.githubusercontent.com/226170/32688635-979ef690-c6dd-11e7-8869-49da7e0f0a11.png)
![proxy_preview](https://user-images.githubusercontent.com/226170/31521305-99c43f22-afb1-11e7-9daf-d1ed6347daa8.png)
![image](https://user-images.githubusercontent.com/226170/31680585-72706098-b37d-11e7-88ad-028c4c723f42.png)

Tree-SHA512: e5f18c20c0be292256a3e78c91cdf390a3b6084346a192a8170460f706f5b6cd198ba5b0035798a85a442fe7f262cf1c2350064670085ff8f473f880ab5ba589

Backport of Core PR11491
https://github.com/bitcoin/bitcoin/pull/11491/

Test Plan
make check
bitcoin-qt -proxy=<valid proxy>

However cursor over the P symbol in the bottom right corner until small window detailing proxy information appears.

pr11491post.png (71×160 px, 3 KB)

bitcoin-qt

The P symbol should not appear because no proxy is being used.

pr11491pre.png (77×122 px, 1 KB)

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nakihito created this revision.Oct 19 2019, 04:29
Owners added a reviewer: Restricted Owners Package.Oct 19 2019, 04:29
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 19 2019, 04:29
Herald added a reviewer: deadalnix. · View Herald Transcript
nakihito planned changes to this revision.Oct 19 2019, 04:29
teamcity added a comment.Oct 19 2019, 04:29

Build Bitcoin-ABC / Diffs / Diff Testing started.

nakihito requested review of this revision.Oct 19 2019, 04:33
nakihito edited the test plan for this revision. (Show Details)
nakihito added reviewers: Fabien, jasonbcox.
teamcity added a comment.Oct 19 2019, 04:40

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7816: Diff 13619.Oct 19 2019, 04:40
nakihito added a child revision: D4270: Merge #13248: [gui] Make proxy icon from statusbar clickable.Oct 19 2019, 04:47
deadalnix accepted this revision.Oct 21 2019, 00:39
This revision is now accepted and ready to land.Oct 21 2019, 00:39
Closed by commit rABCbc8ad5ec1d81: Merge #11491: [gui] Add proxy icon in statusbar (authored by Jonas Schnelli <dev@jonasschnelli.ch>, committed by nakihito). · Explain WhyOct 21 2019, 17:31
This revision was automatically updated to reflect the committed changes.
Nico Guiton <nico@bitframe.org> added a commit: rABCbc8ad5ec1d81: Merge #11491: [gui] Add proxy icon in statusbar.
nakihito added a commit: rSTAGINGbc8ad5ec1d81: Merge #11491: [gui] Add proxy icon in statusbar.Apr 7 2020, 21:28

Revision Contents
Changeset List

PathSize
contrib/
debian/
8 lines
src/
1 line
qt/
1 line
5 lines
25 lines
2 lines
11 lines
res/
icons/
src/
70 lines

Diff 13625

View Options

contrib/debian/copyright

Loading...
View Options

src/Makefile.qt.include

Loading...
View Options

src/qt/bitcoin.qrc

Loading...
View Options

src/qt/bitcoingui.h

Loading...
View Options

src/qt/bitcoingui.cpp

Loading...
View Options

src/qt/clientmodel.h

Loading...
View Options

src/qt/clientmodel.cpp

Loading...
View Options

src/qt/res/icons/proxy.png

Loading...
View Options

src/qt/res/src/proxy.svg

Loading...