This is a partial backport of Core PR13557 : https://github.com/bitcoin/bitcoin/pull/13557/commits/41c607f09badb2c3ed58ff6fb17a8ebbef2cdabd
Details
Details
- Reviewers
Fabien jasonbcox - Group Reviewers
Restricted Project - Commits
- rSTAGING961326309588: Implement PSBT Structures and un/serialization methods per BIP 174
rABC961326309588: Implement PSBT Structures and un/serialization methods per BIP 174
Unfortunately, The PR dump all the tests at once at the end, so there are n test for the new code :/
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- pbststructures
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 7833 Build 13688: Bitcoin ABC Buildbot (legacy) Build 13687: arc lint + arc unit
Event Timeline
| src/script/sign.h | ||
|---|---|---|
| 121 ↗ | (On Diff #13563) | Nit: missing dot. |
| 437 ↗ | (On Diff #13563) | Nit: trailing space |
| 453 ↗ | (On Diff #13563) | Simply use a.tx == b.tx ? The == operator is defined for CMutableTransaction. |
| 524 ↗ | (On Diff #13563) | Nit: remove scriptWitness |
| 530 ↗ | (On Diff #13563) | Dito. |
| 562 ↗ | (On Diff #13563) | Why did you remove the check here ? |
| src/script/sign.h | ||
|---|---|---|
| 562 ↗ | (On Diff #13563) | We only do what they call witness utxo. While we don't have segwit, we do use a similar sighash algorithm. |
| src/script/sign.h | ||
|---|---|---|
| 104 ↗ | (On Diff #13664) | If our UTXOs are "witness utxos" then is it more accurate to have this value be 0x01 to match Core? This caused some mild confusion while comparing to the original PR. |
| 463 ↗ | (On Diff #13664) | nit: unnecessary newline |
| 437 ↗ | (On Diff #13563) | Nit: If you're going to reformat this comment, do it to the rest in this file that are the form /** ... */ |
| src/script/sign.h | ||
|---|---|---|
| 169 ↗ | (On Diff #13664) | unsigned int -> uint64_t |
| src/script/sign.h | ||
|---|---|---|
| 104 ↗ | (On Diff #13664) | There is no reason to set it to 1. |