Various fixups for PR13557
ClosedPublic
Actions

Authored by deadalnix on Oct 30 2019, 21:58.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rSTAGINGf47f339d04c8: Various fixups for PR13557
rABCf47f339d04c8: Various fixups for PR13557

Summary

PSBTInput do nto always serialize its utxo in, so the current behavior is incorrect.

Test Plan

As always, tests will come at the end of PR13557's backport.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr13557nits

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7918
Build 13846: Bitcoin ABC Buildbot (legacy)
Build 13845: arc lint + arc unit

Event Timeline

deadalnix created this revision.Oct 30 2019, 21:58

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 30 2019, 21:58

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B7918: Diff 13799.Oct 30 2019, 22:14

Build Bitcoin-ABC / Diffs / Diff Testing passed.

The code looks good, but the PublicOnlySigningProvider is unrelated to the title and summary of the diff.
Can you split it apart, or add some content into the summary/title ?

This revision now requires changes to proceed.Nov 1 2019, 00:09

In D4322#104831, @Fabien wrote:

The code looks good, but the PublicOnlySigningProvider is unrelated to the title and summary of the diff.
Can you split it apart, or add some content into the summary/title ?

It was definitively added as a mistake.

Remove PublicOnlySigningProvider

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7950: Diff 13860.Nov 1 2019, 12:40

Fabien accepted this revision.Nov 1 2019, 15:10

This revision is now accepted and ready to land.Nov 1 2019, 15:10

Closed by commit rABCf47f339d04c8: Various fixups for PR13557 (authored by deadalnix). · Explain WhyNov 1 2019, 16:48

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCf47f339d04c8: Various fixups for PR13557.

deadalnix added a commit: rSTAGINGf47f339d04c8: Various fixups for PR13557.Apr 7 2020, 21:34