[CMAKE] Create a distribution directory with translations
ClosedPublic
Actions

Authored by Fabien on Nov 5 2019, 14:57.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGINGa89e8e99843f: [CMAKE] Create a distribution directory with translations
rABCa89e8e99843f: [CMAKE] Create a distribution directory with translations

Summary

This diff adds the osx-deploydir target to initiate the dist
directory structure, that will later be used to generate the DMG image
(OSX installer).
The dist directory contains the application bundle augmented with some
Qt translation files to support localization.

Depends on D4379.

Test Plan

ninja osx-deploydir

Check the dist directory contains the application bundle with the
translation files (see the Resources directory inside the application
bundle).

Diff Detail

Repository

rABC Bitcoin ABC

Branch

cmake_osx_dist_translations

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 8022
Build 14041: Bitcoin ABC Buildbot (legacy)
Build 14040: arc lint + arc unit

Event Timeline

Fabien created this revision.Nov 5 2019, 14:57

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 5 2019, 14:57

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7988: Diff 13922.Nov 5 2019, 15:06

Fabien added a child revision: D4381: [CMAKE] Add the background image to the dist directory.Nov 5 2019, 15:18

It appears that CMAKE_INSTALL_NAME_TOOL is an existing undocumented CMake variable.
Use it instead of creating a new duplicate, and use the same syntax for otool.