Log debug build status and warn when running benchmarks
ClosedPublic
Actions

Authored by majcosta on Dec 10 2019, 19:33.

Details

Reviewers

deadalnix
nakihito
Fabien

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGING81c6819f381f: Log debug build status and warn when running benchmarks
rABC81c6819f381f: Log debug build status and warn when running benchmarks

Summary

"34328b4 Use PACKAGE_NAME instead of hardcoding application name in log message (Wladimir J. van der Laan)
0c74e2e Log debug build status and warn when running benchmarks (Wladimir J. van der Laan)

Pull request description:

Log whether the starting instance of bitcoin core is a debug or release build (--enable-debug).

Also warn when running the benchmarks with a debug build, to prevent mistakes comparing debug to non-debug results."

This is a backport from Core PR12197: https://github.com/bitcoin/bitcoin/pull/12197

Test Plan

cmake .. -DCMAKE_BUILD_TYPE=Debug -GNinja  
ninja check
ninja bench-bitcoin

Diff Detail

Repository

rABC Bitcoin ABC

Branch

backport-dec10

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 8487
Build 14985: Default Diff Build & Tests
Build 14984: arc lint + arc unit

Event Timeline

majcosta created this revision.Dec 10 2019, 19:33

Owners added a reviewer: Restricted Owners Package.Dec 10 2019, 19:33

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 10 2019, 19:33

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8481: Diff 14733.Dec 10 2019, 19:47

Test plan doesn't cover the changes. You need to build in debug mode using cmake -DCMAKE_BUILD_TYPE=Debug ... Make sure you run ninja bench-bitcoin and update your test plan as well.

This revision now requires changes to proceed.Dec 10 2019, 19:59

reverting previous code to keep divergence from Core code to a minimum

majcosta edited the test plan for this revision. (Show Details)Dec 10 2019, 21:00

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8486: Diff 14741.Dec 10 2019, 21:15

Fabien requested changes to this revision.Dec 10 2019, 21:27

Fabien added a subscriber: Fabien.

Fabien added inline comments.