The lifetime of the lock is extended in FinalizeBlockAndInvalidate, according to @markblundeberg 's comment on D4942.
Details
Details
- Reviewers
deadalnix markblundeberg - Group Reviewers
Restricted Project
- Build with Clang in Debug mode:
CXX=clang++ CC=clang cmake .. -D CMAKE_CXX_FLAGS="-Werror=thread-safety-analysis" -GNinja -DCMAKE_BUILD_TYPE=Debug ninja check-all
- Verify that the compiler has not emitted a thread-safety warning.
- Run the node: ./src/bitcoind -regtest
- Verify that text similar to "Assertion failed: lock ... not held ..." is not printed on stderr.
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- feature-revert-D4942-lock-time
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 8953 Build 15879: Default Diff Build & Tests Build 15878: arc lint + arc unit
Event Timeline
Comment Actions
This is still not correct as any number of reorg can occur in between the finalization and the invalidate..