Page MenuHomePhabricator
Differential D4959

Revert "Prevent callback overruns in InvalidateBlock and RewindBlockIndex"
ClosedPublic
Actions

Authored by Fabien on Jan 16 2020, 12:04.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING9f7f0d41b929: Revert "Prevent callback overruns in InvalidateBlock and RewindBlockIndex"
rABC9f7f0d41b929: Revert "Prevent callback overruns in InvalidateBlock and RewindBlockIndex"
Summary

This reverts commit a9734a4e30ae12336bce10ef16cd6fd1198b3034.

Similar to D4950 but using git revert.

Test Plan
ABC_BUILD_NAME=build-tsan ./contrib/teamcity/build-configurations.sh

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix_tsan
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8977
Build 15919: Default Diff Build & Tests
Build 15918: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 16 2020, 12:04
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 16 2020, 12:04
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Jan 16 2020, 12:05

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jan 16 2020, 12:09

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8977: Diff 15517.Jan 16 2020, 12:09
teamcity added a comment.Jan 16 2020, 12:24

Build Bitcoin-ABC / Diffs (Resource Intensive) / Resource Intensive Diff Testing started.

teamcity added a comment.Jan 16 2020, 12:32

Build Bitcoin-ABC / Diffs (Resource Intensive) / Resource Intensive Diff Testing passed.

Fabien edited the summary of this revision. (Show Details)Jan 16 2020, 17:58
jasonbcox accepted this revision.Jan 16 2020, 18:06
This revision is now accepted and ready to land.Jan 16 2020, 18:06
jasonbcox mentioned this in D4950: Fully revert D4803 due to TSAN test failures.Jan 16 2020, 18:07
Closed by commit rABC9f7f0d41b929: Revert "Prevent callback overruns in InvalidateBlock and RewindBlockIndex" (authored by Fabien). · Explain WhyJan 16 2020, 18:09
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC9f7f0d41b929: Revert "Prevent callback overruns in InvalidateBlock and RewindBlockIndex".
Fabien added a commit: rSTAGING9f7f0d41b929: Revert "Prevent callback overruns in InvalidateBlock and RewindBlockIndex".Apr 7 2020, 22:28
majcosta mentioned this in D7213: [backport#15402] Prevent callback overruns in InvalidateBlock and RewindBlockIndex.Aug 18 2020, 15:53
majcosta mentioned this in rABCc0c79f53e5c7: [backport#15402] Prevent callback overruns in InvalidateBlock and….Aug 21 2020, 15:06

Revision Contents
Changeset List

PathSize
src/
27 lines

Diff 15517

View Options

src/validation.cpp

Loading...