Merge #13861: test: Add testing of value_ret for SelectCoinsBnB
ClosedPublic
Actions

Authored by nakihito on Jan 16 2020, 19:56.

Details

Reviewers

deadalnix
Fabien
jasonbcox

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGING4a3dbc08a60d: Merge #13861: test: Add testing of value_ret for SelectCoinsBnB
rABC4a3dbc08a60d: Merge #13861: test: Add testing of value_ret for SelectCoinsBnB

Summary

384273260a6ccbcf79dade0830011f528e5a1581 test: Add testing of value_ret for SelectCoinsBnB (Ben Woosley)

Pull request description:

Fix that the early bailout optimization tests did not test the intended
selection because their utxo pool was polluted by the make_hard_case test
preceding. Note the code was tested, just not with the constructed case.

Tree-SHA512: 95f665525f5922f70f4c17708c0c09900f38d7a652b5bdd817e017ba7ff2865a6234edbd340064ffccc20d34048c45df86a4ac5f46dd8f4aab98834e71dc9d3c

Backport of Core PR13861
https://github.com/bitcoin/bitcoin/pull/13861/

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR13861

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 8983
Build 15929: Default Diff Build & Tests
Build 15928: arc lint + arc unit

Event Timeline

nakihito created this revision.Jan 16 2020, 19:56

Owners added a reviewer: Restricted Owners Package.Jan 16 2020, 19:56

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 16 2020, 19:56

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8983: Diff 15526.Jan 16 2020, 20:01

deadalnix accepted this revision.Jan 16 2020, 20:41

This revision is now accepted and ready to land.Jan 16 2020, 20:41

Closed by commit rABC4a3dbc08a60d: Merge #13861: test: Add testing of value_ret for SelectCoinsBnB (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by nakihito). · Explain WhyJan 16 2020, 21:30

This revision was automatically updated to reflect the committed changes.

nakihito added a commit: rABC4a3dbc08a60d: Merge #13861: test: Add testing of value_ret for SelectCoinsBnB.

nakihito added a commit: rSTAGING4a3dbc08a60d: Merge #13861: test: Add testing of value_ret for SelectCoinsBnB.Apr 7 2020, 22:29

Revision Contents
Changeset List

Path

Size

src/

wallet/

test/

coinselector_tests.cpp

10 lines

Diff 15526

View Options

src/wallet/test/coinselector_tests.cpp

Merge #13861: test: Add testing of value_ret for SelectCoinsBnBClosedPublicActions