Page MenuHomePhabricator
Differential D5078

Pass chain locked variables where needed
ClosedPublic
Actions

Authored by Fabien on Jan 27 2020, 14:02.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGdb7b0b599e41: Pass chain locked variables where needed
rABCdb7b0b599e41: Pass chain locked variables where needed
Summary

This commit does not change behavior. All it does is pass new function
parameters.

Partial backport of core PR14437:
https://github.com/bitcoin/bitcoin/pull/14437/commits/081accb875412f38718f2e40ed7bbdf15e6f4ef8

Depends on D5075.

Test Plan
cmake -GNinja .. -DENABLE_WERROR=ON -DCMAKE_BUILD_TYPE=Debug
ninja check check-fonctional

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14437_part4
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9154
Build 16266: Default Diff Build & Tests
Build 16265: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 27 2020, 14:02
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 27 2020, 14:02
teamcity edited the summary of this revision. (Show Details)Jan 27 2020, 14:02

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jan 27 2020, 14:02

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

Fabien edited the summary of this revision. (Show Details)Jan 27 2020, 14:03
Fabien added inline comments.
src/wallet/wallet.cpp
2988

Note to reviewers: renamed to prevent shadowing.

3052

Would be shadowed here.

teamcity added a comment.Jan 27 2020, 14:09

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9154: Diff 15809.Jan 27 2020, 14:09
Fabien added a child revision: D5079: Remove direct node->wallet calls in init.cpp.Jan 27 2020, 15:47
deadalnix accepted this revision.Jan 27 2020, 16:28
This revision is now accepted and ready to land.Jan 27 2020, 16:28
Closed by commit rABCdb7b0b599e41: Pass chain locked variables where needed (authored by Russell Yanofsky <russ@yanofsky.org>, committed by Fabien). · Explain WhyJan 27 2020, 17:06
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCdb7b0b599e41: Pass chain locked variables where needed.
Fabien mentioned this in T711: Build Bitcoin-ABC / Master / Bitcoin-ABC Master Warnings as Errors is broken..Jan 27 2020, 17:20
nakihito mentioned this in D5316: Merge #14023: Remove accounts rpcs.Mar 5 2020, 23:11
Fabien added a commit: rSTAGINGdb7b0b599e41: Pass chain locked variables where needed.Apr 7 2020, 22:40

Revision Contents
Changeset List

PathSize
src/
interfaces/
63 lines
8 lines
wallet/
2 lines
109 lines
test/
19 lines
79 lines
161 lines

Diff 15809

View Options

src/interfaces/wallet.cpp

Loading...
View Options

src/threadsafety.h

Loading...
View Options

src/wallet/rpcdump.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/test/wallet_tests.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...