Differential D5079

Remove direct node->wallet calls in init.cpp
ClosedPublic
Actions

Authored by Fabien on Jan 27 2020, 15:47.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING2ac79363affe: Remove direct node->wallet calls in init.cpp
rABC2ac79363affe: Remove direct node->wallet calls in init.cpp

Summary

Route calls during node initialization and shutdown that would happen
between a node process and wallet processes through the serializable
`Chain::Client` interface, rather than `WalletInitInterface` which is
now simpler and only deals with early initialization and parameter
interaction.

This commit mostly does not change behavior. The only change is that the
"Wallet disabled!" and "No wallet support compiled in!" messages are now
logged earlier during startup.

Completes backport of core PR14437:
https://github.com/bitcoin/bitcoin/pull/14437/commits/ea961c3d7256c66146b4976ab1293db4a628c0de

Depends on D5078.
Completes T592.

Test Plan

ninja check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR14437_part5

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 9155
Build 16268: Default Diff Build & Tests
Build 16267: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 27 2020, 15:47

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 27 2020, 15:47

Build Bitcoin-ABC / Diffs / Diff Testing started.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

Fabien edited the summary of this revision. (Show Details)Jan 27 2020, 15:48

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9155: Diff 15810.Jan 27 2020, 15:52

Fabien mentioned this in T710: Build Bitcoin-ABC / Master / Bitcoin-ABC Master Autotools is broken..Jan 27 2020, 16:32

Fabien added a child revision: D5080: rpc: Make unloadwallet wait for complete wallet unload.Jan 27 2020, 16:39

jasonbcox requested changes to this revision.Jan 27 2020, 20:23

jasonbcox added a subscriber: jasonbcox.

jasonbcox added inline comments.

src/wallet/init.cpp
255	Looks like this removal was missed.

This revision now requires changes to proceed.Jan 27 2020, 20:23

Fix missing removal.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9162: Diff 15824.Jan 28 2020, 07:15

jasonbcox accepted this revision.Jan 28 2020, 19:13

This revision is now accepted and ready to land.Jan 28 2020, 19:13

Closed by commit rABC2ac79363affe: Remove direct node->wallet calls in init.cpp (authored by Russell Yanofsky <russ@yanofsky.org>, committed by Fabien). · Explain WhyJan 28 2020, 20:40

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC2ac79363affe: Remove direct node->wallet calls in init.cpp.

Fabien added a commit: rSTAGING2ac79363affe: Remove direct node->wallet calls in init.cpp.Apr 7 2020, 22:41

Revision Contents
Changeset List

Path

Size

src/

3 lines

1 line

dummywallet.cpp

13 lines

37 lines

interfaces/

21 lines

23 lines

wallet/

66 lines

test/

init_test_fixture.h

1 line

init_test_fixture.cpp

2 lines

14 lines

24 lines

walletinitinterface.h

23 lines

Diff 15810

src/CMakeLists.txt

Loading...

src/Makefile.am

Loading...

src/dummywallet.cpp

Loading...

src/init.cpp

Loading...

src/interfaces/chain.h

Loading...

src/interfaces/wallet.cpp

Loading...

src/wallet/init.cpp

Loading...

src/wallet/test/init_test_fixture.h

Loading...

src/wallet/test/init_test_fixture.cpp

Loading...

src/wallet/test/init_tests.cpp

Loading...

src/wallet/wallet.h

Loading...

src/walletinitinterface.h

Loading...