Page MenuHomePhabricator
Differential D619

Refactor GetDifficulty from RPC
ClosedPublic
Actions

Authored by deadalnix on Oct 19 2017, 14:27.

Details

Reviewers
schancel
Group Reviewers
Restricted Project
Commits
rSTAGING25fbcf451e5f: Refactor GetDifficulty from RPC
rABC25fbcf451e5f: Refactor GetDifficulty from RPC
Summary

It doesn't go fetch global state implicitely now and is declared is the proper header.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
getdifficultyreface
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1014
Build 1014: arc lint + arc unit

Event Timeline

deadalnix created this revision.Oct 19 2017, 14:27
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 19 2017, 14:27
Harbormaster completed remote builds in B1014: Diff 1591.Oct 19 2017, 14:27
schancel accepted this revision.Oct 20 2017, 04:04

chainActive.Tip() is a threadsafe singleton class?

src/rpc/server.h
222

This is pretty strange. Can't help but wonder why they did this that way.

This revision is now accepted and ready to land.Oct 20 2017, 04:04
deadalnix added a comment.Oct 20 2017, 22:33

The singleton is not thread safe, you need to lock onto cs_main or the code is invalid.

src/rpc/server.h
222

There is a lot of historical weirdness in that codebase.

Closed by commit rABC25fbcf451e5f: Refactor GetDifficulty from RPC (authored by deadalnix, committed by deadalnix). · Explain WhyOct 20 2017, 22:33
This revision was automatically updated to reflect the committed changes.
markblundeberg mentioned this in D3012: Backport current GetDifficulty logic (& tests) from Core.May 10 2019, 04:27
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rABCf0c3148e5a72: Backport current GetDifficulty logic (& tests) from Core.May 28 2019, 23:29
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rSTAGINGf0c3148e5a72: Backport current GetDifficulty logic (& tests) from Core.Sep 18 2019, 23:53

Revision Contents
Changeset List

PathSize
src/
rpc/
3 lines
32 lines
7 lines
7 lines
1 line

Diff 1591

View Options

src/rpc/blockchain.h

Loading...
View Options

src/rpc/blockchain.cpp

Loading...
View Options

src/rpc/mining.cpp

Loading...
View Options

src/rpc/misc.cpp

Loading...
View Options

src/rpc/server.h

Loading...