Page MenuHomePhabricator
Differential D5214

Merge #13152: [rpc] Add getnodeaddresses RPC command
ClosedPublic
Actions

Authored by nakihito on Feb 8 2020, 00:05.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING48916ac8540e: Merge #13152: [rpc] Add getnodeaddresses RPC command
rABC48916ac8540e: Merge #13152: [rpc] Add getnodeaddresses RPC command
Summary

a2eb6f5405 [rpc] Add getnodeaddresses RPC command (chris-belcher)

Pull request description:

Implements issue https://github.com/bitcoin/bitcoin/issues/9463

New getnodeaddresses call gives access via RPC to the peers known by the node. It may be useful for bitcoin wallets to broadcast their transactions over tor for improved privacy without using the centralized DNS seeds. getnodeaddresses is very similar to the getaddr p2p method.

Please advise me on the best approach for writing an automated test. By my reading the getaddr p2p method also isn't really tested.

Tree-SHA512: ad03abf518847476495b76a2f5394b8030aa86654429167fa618e21460abb505c10ef9817ec1b80472320d41d0aff5dc94a8efce023aaaaf5e81386aa92b852b

Backport of Core PR13152

Test Plan
ninja check
ninja check-functional

./bitcoind
./bitcoin-cli help getnodeaddresses

Verify help text

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR13152
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9346
Build 16624: Default Diff Build & Tests
Build 16623: arc lint + arc unit

Event Timeline

nakihito created this revision.Feb 8 2020, 00:05
Owners added a reviewer: Restricted Owners Package.Feb 8 2020, 00:05
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 8 2020, 00:05
teamcity edited the summary of this revision. (Show Details)Feb 8 2020, 00:06

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

teamcity added a comment.Feb 8 2020, 00:06

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Feb 8 2020, 00:11
Build Bitcoin-ABC / Diffs / Diff Testing failed.

Snippet of first build failure:

[00:10:39]F:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_LockDirectory
[00:10:39]i:			 [util_tests.test_LockDirectory] [Test Error Output]
Failures detected in:
- test case: util_tests/test_LockDirectory
- file: util_tests.cpp
- line: 1290
[00:10:39]F:			 [util_tests.test_LockDirectory] assertion error: failure
[00:10:39]F:			 [util_tests.test_LockDirectory] ASSERTION FAILURE:
- file   : util_tests.cpp
- line   : 1368
- message: check processstatus == 0 has failed [11 != 0]
[00:10:40]E:	 [Step 1/1] Failed tests detected
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_DirIsWritable
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_ConvertBits
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_ToLower
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_ToUpper
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_Capitalize
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] validation_block_tests.processnewblock_signals_ordering
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] validation_tests.block_subsidy_test
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] validation_tests.subsidy_limit_test
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] validation_tests.validation_load_external_block_file
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] versionbits_tests.versionbits_test
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] versionbits_tests.versionbits_computeblockversion
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] work_comparator_tests.work_comparator
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] server_tests.server_IsDeprecatedRPCEnabled
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] accounting_tests.acc_orderupgrade
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] db_tests.getwalletenv_file
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] db_tests.getwalletenv_directory
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] db_tests.getwalletenv_g_dbenvs_multiple
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] db_tests.getwalletenv_g_dbenvs_free_instance
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] coinselector_tests.bnb_search_test
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] coinselector_tests.knapsack_solver_test
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] coinselector_tests.ApproximateBestSubset
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] coinselector_tests.SelectCoins_test
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] init_tests.walletinit_verify_walletdir_default
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] init_tests.walletinit_verify_walletdir_custom
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] init_tests.walletinit_verify_walletdir_does_not_exist
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] init_tests.walletinit_verify_walletdir_is_not_directory
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] init_tests.walletinit_verify_walletdir_is_not_relative
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] init_tests.walletinit_verify_walletdir_no_trailing
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] init_tests.walletinit_verify_walletdir_no_trailing2
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] psbt_wallet_tests.psbt_updater_test
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] psbt_wallet_tests.parse_hd_keypath
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_tests.rescan
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_tests.importwallet_rescan
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_tests.coin_mark_dirty_immature_credit
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_tests.ComputeTimeSmart
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_tests.LoadReceiveRequests
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_tests.ListCoins
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_tests.wallet_disableprivkeys
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] walletdb_tests.write_erase_name
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] walletdb_tests.write_erase_purpose
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] walletdb_tests.write_erase_destdata
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] walletdb_tests.no_dest_fails
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_crypto_tests.passphrase
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_crypto_tests.encrypt
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_crypto_tests.decrypt
[00:10:39]W:	 [Step 1/1]  [0;39;49m
[00:10:39]W:	 [Step 1/1] Process exited with code 201
[00:10:40]E:	 [Step 1/1] Process exited with code 201 (Step: Command Line)

Each failure log is accessible here:
Bitcoin_ABC_unit_tests_with_next_upgrade_activated: util_tests.test_LockDirectory

Harbormaster failed remote builds in B9346: Diff 16158!Feb 8 2020, 00:11
teamcity added a comment.Feb 8 2020, 01:19

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Feb 8 2020, 01:23
Build Bitcoin-ABC / Diffs / Diff Testing failed.

Snippet of first build failure:

[01:21:16]i:		 [Bitcoin_ABC_unit_tests] init_tests.walletinit_verify_walletdir_is_not_relative
[01:21:16]i:		 [Bitcoin_ABC_unit_tests] init_tests.walletinit_verify_walletdir_no_trailing
[01:21:16]i:		 [Bitcoin_ABC_unit_tests] init_tests.walletinit_verify_walletdir_no_trailing2
[01:21:16]i:		 [Bitcoin_ABC_unit_tests] psbt_wallet_tests.psbt_updater_test
[01:21:16]i:		 [Bitcoin_ABC_unit_tests] psbt_wallet_tests.parse_hd_keypath
[01:21:16]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.rescan
[01:21:16]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.importwallet_rescan
[01:21:16]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.coin_mark_dirty_immature_credit
[01:21:16]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.ComputeTimeSmart
[01:21:16]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.LoadReceiveRequests
[01:21:16]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.ListCoins
[01:21:16]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.wallet_disableprivkeys
[01:21:16]i:		 [Bitcoin_ABC_unit_tests] walletdb_tests.write_erase_name
[01:21:16]i:		 [Bitcoin_ABC_unit_tests] walletdb_tests.write_erase_purpose
[01:21:16]i:		 [Bitcoin_ABC_unit_tests] walletdb_tests.write_erase_destdata
[01:21:16]i:		 [Bitcoin_ABC_unit_tests] walletdb_tests.no_dest_fails
[01:21:16]i:		 [Bitcoin_ABC_unit_tests] wallet_crypto_tests.passphrase
[01:21:16]i:		 [Bitcoin_ABC_unit_tests] wallet_crypto_tests.encrypt
[01:21:16]i:		 [Bitcoin_ABC_unit_tests] wallet_crypto_tests.decrypt
[01:22:41] :	 [Step 1/1] Running 454 test cases...
[01:22:41] :	 [Step 1/1] 
[01:22:41] :	 [Step 1/1] Assertion occurred in a following context:
[01:22:41] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:341
[01:22:41] :	 [Step 1/1] Assertion occurred in a following context:
[01:22:41] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:341
[01:22:41] :	 [Step 1/1] Assertion occurred in a following context:
[01:22:41] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:341
[01:22:41] :	 [Step 1/1] Assertion occurred in a following context:
[01:22:41] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:341
[01:22:41] :	 [Step 1/1] Assertion occurred in a following context:
[01:22:41] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:345
[01:22:41] :	 [Step 1/1] Assertion occurred in a following context:
[01:22:41] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:345
[01:22:41] :	 [Step 1/1] Assertion occurred in a following context:
[01:22:41] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:345
[01:22:41] :	 [Step 1/1] Assertion occurred in a following context:
[01:22:41] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:345
[01:22:41] :	 [Step 1/1] Assertion occurred in a following context:
[01:22:41] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:355
[01:22:41] :	 [Step 1/1] Assertion occurred in a following context:
[01:22:41] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:355
[01:22:41] :	 [Step 1/1] Assertion occurred in a following context:
[01:22:41] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:355
[01:22:41] :	 [Step 1/1] Assertion occurred in a following context:
[01:22:41] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:355
[01:22:41] :	 [Step 1/1] Assertion occurred in a following context:
[01:22:41] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:365
[01:22:41] :	 [Step 1/1] Assertion occurred in a following context:
[01:22:41] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:365
[01:22:41] :	 [Step 1/1] Assertion occurred in a following context:
[01:22:41] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:365
[01:22:41] :	 [Step 1/1] Assertion occurred in a following context:
[01:22:47]W:	 [Step 1/1] corrupted double-linked list
[01:22:47] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:365../src/test/util_tests.cpp(1368):  [1;31;49merror: in "util_tests/test_LockDirectory": check processstatus == 0 has failed [11 != 0] [0;39;49m
[01:22:53] :	 [Step 1/1] 30000000
[01:22:53]W:	 [Step 1/1] 
[01:22:53]W:	 [Step 1/1]  [1;31;49m*** 1 failure is detected in the test module "Bitcoin ABC unit tests with next upgrade activated"
[01:22:53]W:	 [Step 1/1]  [0;39;49m
[01:22:53]W:	 [Step 1/1] Process exited with code 201
[01:22:53]E:	 [Step 1/1] Process exited with code 201 (Step: Command Line)

Each failure log is accessible here:
Bitcoin_ABC_unit_tests_with_next_upgrade_activated: util_tests.test_LockDirectory

nakihito planned changes to this revision.Feb 8 2020, 01:24

Investigating build failures.

nakihito updated this revision to Diff 16249.Feb 11 2020, 01:38

Rebased.

nakihito planned changes to this revision.Feb 11 2020, 01:38
teamcity added a comment.Feb 11 2020, 01:38

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Feb 11 2020, 01:43
Build Bitcoin-ABC / Diffs / Diff Testing failed.

Snippet of first build failure:

[01:41:23]i:		 [Bitcoin_ABC_unit_tests] init_tests.walletinit_verify_walletdir_is_not_directory
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] init_tests.walletinit_verify_walletdir_is_not_relative
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] init_tests.walletinit_verify_walletdir_no_trailing
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] init_tests.walletinit_verify_walletdir_no_trailing2
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] psbt_wallet_tests.psbt_updater_test
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] psbt_wallet_tests.parse_hd_keypath
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.rescan
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.importwallet_rescan
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.coin_mark_dirty_immature_credit
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.ComputeTimeSmart
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.LoadReceiveRequests
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.ListCoins
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.wallet_disableprivkeys
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] walletdb_tests.write_erase_name
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] walletdb_tests.write_erase_purpose
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] walletdb_tests.write_erase_destdata
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] walletdb_tests.no_dest_fails
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] wallet_crypto_tests.passphrase
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] wallet_crypto_tests.encrypt
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] wallet_crypto_tests.decrypt
[01:42:52] :	 [Step 1/1] Running 454 test cases...
[01:42:52] :	 [Step 1/1] 
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:341
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:341
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:341
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:341
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:345
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:345
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:345
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:345
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:355
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:355
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:355
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:355
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:365
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:365
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:365
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:58]W:	 [Step 1/1] corrupted double-linked list
[01:42:58] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:365../src/test/util_tests.cpp(1368):  [1;31;49merror: in "util_tests/test_LockDirectory": check processstatus == 0 has failed [11 != 0] [0;39;49m
[01:43:04]W:	 [Step 1/1] 
[01:43:04]W:	 [Step 1/1]  [1;31;49m*** 1 failure is detected in the test module "Bitcoin ABC unit tests with next upgrade activated"
[01:43:04]W:	 [Step 1/1]  [0;39;49m
[01:43:04]W:	 [Step 1/1] Process exited with code 201
[01:43:04]E:	 [Step 1/1] Process exited with code 201 (Step: Command Line)

Each failure log is accessible here:
Bitcoin_ABC_unit_tests_with_next_upgrade_activated: util_tests.test_LockDirectory

Harbormaster failed remote builds in B9410: Diff 16249!Feb 11 2020, 01:43
markblundeberg added a subscriber: markblundeberg.Feb 11 2020, 02:18
In D5214#126699, @teamcity wrote:
Build Bitcoin-ABC / Diffs / Diff Testing failed.

Snippet of first build failure:

[01:41:23]i:		 [Bitcoin_ABC_unit_tests] init_tests.walletinit_verify_walletdir_is_not_directory
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] init_tests.walletinit_verify_walletdir_is_not_relative
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] init_tests.walletinit_verify_walletdir_no_trailing
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] init_tests.walletinit_verify_walletdir_no_trailing2
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] psbt_wallet_tests.psbt_updater_test
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] psbt_wallet_tests.parse_hd_keypath
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.rescan
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.importwallet_rescan
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.coin_mark_dirty_immature_credit
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.ComputeTimeSmart
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.LoadReceiveRequests
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.ListCoins
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.wallet_disableprivkeys
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] walletdb_tests.write_erase_name
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] walletdb_tests.write_erase_purpose
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] walletdb_tests.write_erase_destdata
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] walletdb_tests.no_dest_fails
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] wallet_crypto_tests.passphrase
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] wallet_crypto_tests.encrypt
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] wallet_crypto_tests.decrypt
[01:42:52] :	 [Step 1/1] Running 454 test cases...
[01:42:52] :	 [Step 1/1] 
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:341
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:341
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:341
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:341
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:345
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:345
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:345
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:345
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:355
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:355
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:355
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:355
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:365
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:365
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:365
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:58]W:	 [Step 1/1] corrupted double-linked list
[01:42:58] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:365../src/test/util_tests.cpp(1368):  [1;31;49merror: in "util_tests/test_LockDirectory": check processstatus == 0 has failed [11 != 0] [0;39;49m
[01:43:04]W:	 [Step 1/1] 
[01:43:04]W:	 [Step 1/1]  [1;31;49m*** 1 failure is detected in the test module "Bitcoin ABC unit tests with next upgrade activated"
[01:43:04]W:	 [Step 1/1]  [0;39;49m
[01:43:04]W:	 [Step 1/1] Process exited with code 201
[01:43:04]E:	 [Step 1/1] Process exited with code 201 (Step: Command Line)

Each failure log is accessible here:
Bitcoin_ABC_unit_tests_with_next_upgrade_activated: util_tests.test_LockDirectory

hey that's not your diff's fault: see D5232

nakihito requested review of this revision.Feb 11 2020, 02:43
teamcity added a comment.Feb 11 2020, 07:48

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Feb 11 2020, 07:53
Build Bitcoin-ABC / Diffs / Diff Testing failed.

Snippet of first build failure:

[07:53:27]F:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_LockDirectory
[07:53:27]i:			 [util_tests.test_LockDirectory] [Test Error Output]
Failures detected in:
- test case: util_tests/test_LockDirectory
- file: util_tests.cpp
- line: 1290
[07:53:27]F:			 [util_tests.test_LockDirectory] assertion error: failure
[07:53:27]F:			 [util_tests.test_LockDirectory] ASSERTION FAILURE:
- file   : util_tests.cpp
- line   : 1368
- message: check processstatus == 0 has failed [11 != 0]
[07:53:28]E:	 [Step 1/1] Failed tests detected
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_DirIsWritable
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_ConvertBits
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_ToLower
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_ToUpper
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_Capitalize
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] validation_block_tests.processnewblock_signals_ordering
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] validation_tests.block_subsidy_test
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] validation_tests.subsidy_limit_test
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] validation_tests.validation_load_external_block_file
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] versionbits_tests.versionbits_test
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] versionbits_tests.versionbits_computeblockversion
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] work_comparator_tests.work_comparator
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] server_tests.server_IsDeprecatedRPCEnabled
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] accounting_tests.acc_orderupgrade
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] db_tests.getwalletenv_file
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] db_tests.getwalletenv_directory
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] db_tests.getwalletenv_g_dbenvs_multiple
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] db_tests.getwalletenv_g_dbenvs_free_instance
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] coinselector_tests.bnb_search_test
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] coinselector_tests.knapsack_solver_test
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] coinselector_tests.ApproximateBestSubset
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] coinselector_tests.SelectCoins_test
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] init_tests.walletinit_verify_walletdir_default
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] init_tests.walletinit_verify_walletdir_custom
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] init_tests.walletinit_verify_walletdir_does_not_exist
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] init_tests.walletinit_verify_walletdir_is_not_directory
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] init_tests.walletinit_verify_walletdir_is_not_relative
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] init_tests.walletinit_verify_walletdir_no_trailing
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] init_tests.walletinit_verify_walletdir_no_trailing2
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] psbt_wallet_tests.psbt_updater_test
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] psbt_wallet_tests.parse_hd_keypath
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_tests.rescan
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_tests.importwallet_rescan
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_tests.coin_mark_dirty_immature_credit
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_tests.ComputeTimeSmart
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_tests.LoadReceiveRequests
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_tests.ListCoins
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_tests.wallet_disableprivkeys
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] walletdb_tests.write_erase_name
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] walletdb_tests.write_erase_purpose
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] walletdb_tests.write_erase_destdata
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] walletdb_tests.no_dest_fails
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_crypto_tests.passphrase
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_crypto_tests.encrypt
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_crypto_tests.decrypt
[07:53:27]W:	 [Step 1/1]  [0;39;49m
[07:53:27]W:	 [Step 1/1] Process exited with code 201
[07:53:28]E:	 [Step 1/1] Process exited with code 201 (Step: Command Line)

Each failure log is accessible here:
Bitcoin_ABC_unit_tests_with_next_upgrade_activated: util_tests.test_LockDirectory

teamcity added a comment.Feb 11 2020, 07:57

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Feb 11 2020, 07:58

Build Bitcoin-ABC / Diffs / Diff Testing started.

markblundeberg added a comment.Feb 11 2020, 07:58
In D5214#126782, @teamcity wrote:
Build Bitcoin-ABC / Diffs / Diff Testing failed.

Geez this bug really hates this diff ... o_O

teamcity added a comment.Feb 11 2020, 08:02
Build Bitcoin-ABC / Diffs / Diff Testing failed.

Snippet of first build failure:

[08:00:18]i:		 [Bitcoin_ABC_unit_tests] init_tests.walletinit_verify_walletdir_is_not_directory
[08:00:18]i:		 [Bitcoin_ABC_unit_tests] init_tests.walletinit_verify_walletdir_is_not_relative
[08:00:18]i:		 [Bitcoin_ABC_unit_tests] init_tests.walletinit_verify_walletdir_no_trailing
[08:00:18]i:		 [Bitcoin_ABC_unit_tests] init_tests.walletinit_verify_walletdir_no_trailing2
[08:00:18]i:		 [Bitcoin_ABC_unit_tests] psbt_wallet_tests.psbt_updater_test
[08:00:18]i:		 [Bitcoin_ABC_unit_tests] psbt_wallet_tests.parse_hd_keypath
[08:00:18]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.rescan
[08:00:18]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.importwallet_rescan
[08:00:18]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.coin_mark_dirty_immature_credit
[08:00:18]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.ComputeTimeSmart
[08:00:18]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.LoadReceiveRequests
[08:00:18]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.ListCoins
[08:00:18]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.wallet_disableprivkeys
[08:00:18]i:		 [Bitcoin_ABC_unit_tests] walletdb_tests.write_erase_name
[08:00:18]i:		 [Bitcoin_ABC_unit_tests] walletdb_tests.write_erase_purpose
[08:00:18]i:		 [Bitcoin_ABC_unit_tests] walletdb_tests.write_erase_destdata
[08:00:18]i:		 [Bitcoin_ABC_unit_tests] walletdb_tests.no_dest_fails
[08:00:18]i:		 [Bitcoin_ABC_unit_tests] wallet_crypto_tests.passphrase
[08:00:18]i:		 [Bitcoin_ABC_unit_tests] wallet_crypto_tests.encrypt
[08:00:18]i:		 [Bitcoin_ABC_unit_tests] wallet_crypto_tests.decrypt
[08:01:44] :	 [Step 1/1] Running 454 test cases...
[08:01:44] :	 [Step 1/1] 
[08:01:44] :	 [Step 1/1] Assertion occurred in a following context:
[08:01:44] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:341
[08:01:44] :	 [Step 1/1] Assertion occurred in a following context:
[08:01:44] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:341
[08:01:44] :	 [Step 1/1] Assertion occurred in a following context:
[08:01:44] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:341
[08:01:44] :	 [Step 1/1] Assertion occurred in a following context:
[08:01:44] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:341
[08:01:44] :	 [Step 1/1] Assertion occurred in a following context:
[08:01:44] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:345
[08:01:44] :	 [Step 1/1] Assertion occurred in a following context:
[08:01:44] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:345
[08:01:44] :	 [Step 1/1] Assertion occurred in a following context:
[08:01:44] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:345
[08:01:44] :	 [Step 1/1] Assertion occurred in a following context:
[08:01:44] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:345
[08:01:44] :	 [Step 1/1] Assertion occurred in a following context:
[08:01:44] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:355
[08:01:44] :	 [Step 1/1] Assertion occurred in a following context:
[08:01:44] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:355
[08:01:44] :	 [Step 1/1] Assertion occurred in a following context:
[08:01:44] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:355
[08:01:44] :	 [Step 1/1] Assertion occurred in a following context:
[08:01:44] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:355
[08:01:44] :	 [Step 1/1] Assertion occurred in a following context:
[08:01:44] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:365
[08:01:44] :	 [Step 1/1] Assertion occurred in a following context:
[08:01:44] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:365
[08:01:44] :	 [Step 1/1] Assertion occurred in a following context:
[08:01:44] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:365
[08:01:44] :	 [Step 1/1] Assertion occurred in a following context:
[08:01:50]W:	 [Step 1/1] corrupted double-linked list
[08:01:50] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:365../src/test/util_tests.cpp(1368):  [1;31;49merror: in "util_tests/test_LockDirectory": check processstatus == 0 has failed [11 != 0] [0;39;49m
[08:01:56]W:	 [Step 1/1] 
[08:01:56]W:	 [Step 1/1]  [1;31;49m*** 1 failure is detected in the test module "Bitcoin ABC unit tests with next upgrade activated"
[08:01:56]W:	 [Step 1/1]  [0;39;49m
[08:01:56]W:	 [Step 1/1] Process exited with code 201
[08:01:56]E:	 [Step 1/1] Process exited with code 201 (Step: Command Line)

Each failure log is accessible here:
Bitcoin_ABC_unit_tests_with_next_upgrade_activated: util_tests.test_LockDirectory

teamcity added a comment.Feb 11 2020, 08:06
Build Bitcoin-ABC / Diffs / Diff Testing failed.

Snippet of first build failure:

[08:04:03]i:		 [Bitcoin_ABC_unit_tests] init_tests.walletinit_verify_walletdir_is_not_directory
[08:04:03]i:		 [Bitcoin_ABC_unit_tests] init_tests.walletinit_verify_walletdir_is_not_relative
[08:04:03]i:		 [Bitcoin_ABC_unit_tests] init_tests.walletinit_verify_walletdir_no_trailing
[08:04:03]i:		 [Bitcoin_ABC_unit_tests] init_tests.walletinit_verify_walletdir_no_trailing2
[08:04:03]i:		 [Bitcoin_ABC_unit_tests] psbt_wallet_tests.psbt_updater_test
[08:04:03]i:		 [Bitcoin_ABC_unit_tests] psbt_wallet_tests.parse_hd_keypath
[08:04:03]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.rescan
[08:04:03]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.importwallet_rescan
[08:04:03]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.coin_mark_dirty_immature_credit
[08:04:03]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.ComputeTimeSmart
[08:04:03]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.LoadReceiveRequests
[08:04:03]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.ListCoins
[08:04:03]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.wallet_disableprivkeys
[08:04:03]i:		 [Bitcoin_ABC_unit_tests] walletdb_tests.write_erase_name
[08:04:03]i:		 [Bitcoin_ABC_unit_tests] walletdb_tests.write_erase_purpose
[08:04:03]i:		 [Bitcoin_ABC_unit_tests] walletdb_tests.write_erase_destdata
[08:04:03]i:		 [Bitcoin_ABC_unit_tests] walletdb_tests.no_dest_fails
[08:04:03]i:		 [Bitcoin_ABC_unit_tests] wallet_crypto_tests.passphrase
[08:04:03]i:		 [Bitcoin_ABC_unit_tests] wallet_crypto_tests.encrypt
[08:04:03]i:		 [Bitcoin_ABC_unit_tests] wallet_crypto_tests.decrypt
[08:05:43] :	 [Step 1/1] Running 454 test cases...
[08:05:43] :	 [Step 1/1] 
[08:05:43] :	 [Step 1/1] Assertion occurred in a following context:
[08:05:43] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:341
[08:05:43] :	 [Step 1/1] Assertion occurred in a following context:
[08:05:43] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:341
[08:05:43] :	 [Step 1/1] Assertion occurred in a following context:
[08:05:43] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:341
[08:05:43] :	 [Step 1/1] Assertion occurred in a following context:
[08:05:43] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:341
[08:05:43] :	 [Step 1/1] Assertion occurred in a following context:
[08:05:43] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:345
[08:05:43] :	 [Step 1/1] Assertion occurred in a following context:
[08:05:43] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:345
[08:05:43] :	 [Step 1/1] Assertion occurred in a following context:
[08:05:43] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:345
[08:05:43] :	 [Step 1/1] Assertion occurred in a following context:
[08:05:43] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:345
[08:05:43] :	 [Step 1/1] Assertion occurred in a following context:
[08:05:43] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:355
[08:05:43] :	 [Step 1/1] Assertion occurred in a following context:
[08:05:43] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:355
[08:05:43] :	 [Step 1/1] Assertion occurred in a following context:
[08:05:43] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:355
[08:05:43] :	 [Step 1/1] Assertion occurred in a following context:
[08:05:43] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:355
[08:05:43] :	 [Step 1/1] Assertion occurred in a following context:
[08:05:43] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:365
[08:05:43] :	 [Step 1/1] Assertion occurred in a following context:
[08:05:43] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:365
[08:05:43] :	 [Step 1/1] Assertion occurred in a following context:
[08:05:43] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:365
[08:05:43] :	 [Step 1/1] Assertion occurred in a following context:
[08:05:50]W:	 [Step 1/1] corrupted double-linked list
[08:05:50] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:365../src/test/util_tests.cpp(1368):  [1;31;49merror: in "util_tests/test_LockDirectory": check processstatus == 0 has failed [11 != 0] [0;39;49m
[08:05:57]W:	 [Step 1/1] 
[08:05:57]W:	 [Step 1/1]  [1;31;49m*** 1 failure is detected in the test module "Bitcoin ABC unit tests with next upgrade activated"
[08:05:57]W:	 [Step 1/1]  [0;39;49m
[08:05:57]W:	 [Step 1/1] Process exited with code 201
[08:05:57]E:	 [Step 1/1] Process exited with code 201 (Step: Command Line)

Each failure log is accessible here:
Bitcoin_ABC_unit_tests_with_next_upgrade_activated: util_tests.test_LockDirectory

markblundeberg added a comment.Feb 11 2020, 08:08

Macro lolfail:

markblundeberg added a comment.Feb 11 2020, 09:33

Should be fixed now by D5254, please rebase.

nakihito updated this revision to Diff 16292.Feb 11 2020, 16:51

Rebased.

teamcity added a comment.Feb 11 2020, 16:51

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Feb 11 2020, 17:01

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9439: Diff 16292.Feb 11 2020, 17:01
jasonbcox requested changes to this revision.Feb 12 2020, 00:44
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/rpc/net.cpp
841 ↗(On Diff #16292)

function-style casting

This revision now requires changes to proceed.Feb 12 2020, 00:44
nakihito updated this revision to Diff 16311.Feb 12 2020, 00:46

Functional style casting.

teamcity added a comment.Feb 12 2020, 00:46

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Feb 12 2020, 01:03

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9452: Diff 16311.Feb 12 2020, 01:04
jasonbcox accepted this revision.Feb 12 2020, 17:27
This revision is now accepted and ready to land.Feb 12 2020, 17:27
Closed by commit rABC48916ac8540e: Merge #13152: [rpc] Add getnodeaddresses RPC command (authored by MarcoFalke <falke.marco@gmail.com>, committed by nakihito). · Explain WhyFeb 12 2020, 18:56
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABC48916ac8540e: Merge #13152: [rpc] Add getnodeaddresses RPC command.
nakihito added a commit: rSTAGING48916ac8540e: Merge #13152: [rpc] Add getnodeaddresses RPC command.Apr 7 2020, 22:58

Revision Contents
Changeset List

PathSize
doc/
5 lines
src/
rpc/
1 line
62 lines
test/
functional/
40 lines

Diff 16158

View Options

doc/release-notes.md

Loading...
View Options

src/rpc/client.cpp

Loading...
View Options

src/rpc/net.cpp

Loading...
View Options

test/functional/rpc_net.py

Loading...