Paths

Table of Contentst

OP_REVERSEBYTES activation logic
ClosedPublic
Actions

Authored by tobias_ruck on Feb 13 2020, 03:05.

Details

Reviewers

deadalnix
markblundeberg

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGING9bd868e48eb0: OP_REVERSEBYTES activation logic
rABC9bd868e48eb0: OP_REVERSEBYTES activation logic

Summary

Fixes a bug in D5130, in the activation logic when building without the bitcoin wallet. Depends on D4871. Based on D3736.

Test Plan

ninja check

test/functional/test_runner.py

test/functional/test_runner.py --with-phononactivation

Also compile with cmake .. -DBUILD_BITCOIN_WALLET=OFF

Diff Detail

Repository

rABC Bitcoin ABC

Branch

arcpatch-D5130_1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 9472
Build 16859: Default Diff Build & Tests
Build 16858: arc lint + arc unit

Event Timeline

tobias_ruck created this revision.Feb 13 2020, 03:05

Owners added a reviewer: Restricted Owners Package.Feb 13 2020, 03:05

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 13 2020, 03:05

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9472: Diff 16341.Feb 13 2020, 03:26

markblundeberg accepted this revision.Feb 13 2020, 03:33

This revision is now accepted and ready to land.Feb 13 2020, 03:33

Closed by commit rABC9bd868e48eb0: OP_REVERSEBYTES activation logic (authored by tobias_ruck). · Explain WhyFeb 13 2020, 05:34

This revision was automatically updated to reflect the committed changes.

tobias_ruck added a commit: rABC9bd868e48eb0: OP_REVERSEBYTES activation logic.

markblundeberg mentioned this in D5245: [qa] Test that mempool reverts to pre-phonon policies.Feb 14 2020, 02:22

tobias_ruck added a commit: rSTAGING9bd868e48eb0: OP_REVERSEBYTES activation logic.Apr 7 2020, 22:59

PiRK mentioned this in D17056: [electrum] remove outdated error message.Thu, Oct 31, 20:21

Revision Contents
Changeset List

Path

Size

src/

validation.cpp

20 lines

test/

functional/

abc-op-reversebytes-activation.py

290 lines

Diff 16341

View Options

src/validation.cpp