[wallet] Remove AccountMove()
ClosedPublic
Actions

Authored by nakihito on Mar 3 2020, 18:39.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGING65cbc5e408c3: [wallet] Remove AccountMove()
rABC65cbc5e408c3: [wallet] Remove AccountMove()

Summary

Function no longer used.

Partial backport of Core PR13825
https://github.com/bitcoin/bitcoin/pull/13825/commits/ad63e017243b6cb0da3b2c00377b8f667cea0957

Depends on D5316

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR13825-2

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 9707
Build 17307: Default Diff Build & Tests
Build 17306: arc lint + arc unit

Event Timeline

nakihito created this revision.Mar 3 2020, 18:39

Owners added a reviewer: Restricted Owners Package.Mar 3 2020, 18:39

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 3 2020, 18:39

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

nakihito edited the summary of this revision. (Show Details)Mar 3 2020, 18:43

nakihito added a parent revision: D5316: Merge #14023: Remove accounts rpcs.

nakihito added a child revision: D5413: [wallet] Remove AddAccountingEntry().Mar 3 2020, 18:59

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9707: Diff 16736.Mar 3 2020, 19:22

nakihito added a child revision: D5418: [wallet] Remove CAccountingEntry class.Mar 3 2020, 20:16

jasonbcox accepted this revision.Mar 3 2020, 23:48

This revision is now accepted and ready to land.Mar 3 2020, 23:48

Closed by commit rABC65cbc5e408c3: [wallet] Remove AccountMove() (authored by nakihito). · Explain WhyMar 6 2020, 00:06

This revision was automatically updated to reflect the committed changes.

nakihito added a commit: rABC65cbc5e408c3: [wallet] Remove AccountMove().

nakihito added a commit: rSTAGING65cbc5e408c3: [wallet] Remove AccountMove().Apr 7 2020, 23:14

Revision Contents
Changeset List

Path

Size

src/

wallet/

wallet.h

3 lines

wallet.cpp

32 lines

Diff 16736

View Options

src/wallet/wallet.h