Page MenuHomePhabricator
Differential D5412

[wallet] Remove CWallet::ListAccountCreditDebit() and GetAccountCreditDebit()
ClosedPublic
Actions

Authored by nakihito on Mar 3 2020, 18:41.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGff8832ec366c: [wallet] Remove CWallet::ListAccountCreditDebit() and GetAccountCreditDebit()
rABCff8832ec366c: [wallet] Remove CWallet::ListAccountCreditDebit() and GetAccountCreditDebit()
Summary

Functions no longer used.

Partial backport of Core PR13825
https://github.com/bitcoin/bitcoin/pull/13825/commits/e6fcc5d39675aced61b4abc25b7d04f398e32318
https://github.com/bitcoin/bitcoin/pull/13825/commits/7a0d8f49b3e2fc8e497e9b41b251cd2c861a6640

Depends on D5316

Test Plan
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR13825-3
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9708
Build 17309: Default Diff Build & Tests
Build 17308: arc lint + arc unit

Event Timeline

nakihito created this revision.Mar 3 2020, 18:41
Owners added a reviewer: Restricted Owners Package.Mar 3 2020, 18:41
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 3 2020, 18:41
teamcity edited the summary of this revision. (Show Details)Mar 3 2020, 18:41

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

nakihito edited the summary of this revision. (Show Details)Mar 3 2020, 18:44
nakihito added a parent revision: D5316: Merge #14023: Remove accounts rpcs.
teamcity added a comment.Mar 3 2020, 19:13

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Mar 3 2020, 19:24

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9708: Diff 16737.Mar 3 2020, 19:24
nakihito added a child revision: D5416: [wallet] Remove ListAccountCreditDebit().Mar 3 2020, 19:54
nakihito added a child revision: D5418: [wallet] Remove CAccountingEntry class.Mar 3 2020, 20:16
jasonbcox accepted this revision.Mar 3 2020, 23:40
This revision is now accepted and ready to land.Mar 3 2020, 23:40
Closed by commit rABCff8832ec366c: [wallet] Remove CWallet::ListAccountCreditDebit() and GetAccountCreditDebit() (authored by nakihito). · Explain WhyMar 6 2020, 00:13
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABCff8832ec366c: [wallet] Remove CWallet::ListAccountCreditDebit() and GetAccountCreditDebit().
nakihito added a commit: rSTAGINGff8832ec366c: [wallet] Remove CWallet::ListAccountCreditDebit() and GetAccountCreditDebit().Apr 7 2020, 23:14

Revision Contents
Changeset List

PathSize
src/
wallet/
2 lines
6 lines
1 line
12 lines

Diff 16737

View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...
View Options

src/wallet/walletdb.h

Loading...
View Options

src/wallet/walletdb.cpp

Loading...