Page MenuHomePhabricator
Differential D5415

[wallet] Don't read acentry key-values from wallet on load.
ClosedPublic
Actions

Authored by nakihito on Mar 3 2020, 19:50.

Details

Reviewers
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGae17dc97a0a7: [wallet] Don't read acentry key-values from wallet on load.
rABCae17dc97a0a7: [wallet] Don't read acentry key-values from wallet on load.
Summary

Partial backport of Core PR13825
https://github.com/bitcoin/bitcoin/pull/13825/commits/a544ab28572de96f3ea0855592abd655ef5d937

Depends on D5316

Test Plan
ninja check
test_runner.py wallet_*

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR13825-6
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9711
Build 17315: Default Diff Build & Tests
Build 17314: arc lint + arc unit

Event Timeline

nakihito created this revision.Mar 3 2020, 19:50
Owners added a reviewer: Restricted Owners Package.Mar 3 2020, 19:50
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 3 2020, 19:50
teamcity edited the summary of this revision. (Show Details)Mar 3 2020, 19:50

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Mar 3 2020, 19:50

Build Bitcoin-ABC / Diffs / Diff Testing started.

nakihito added a child revision: D5416: [wallet] Remove ListAccountCreditDebit().Mar 3 2020, 19:54
teamcity added a comment.Mar 3 2020, 20:00

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9711: Diff 16742.Mar 3 2020, 20:00
nakihito added a child revision: D5418: [wallet] Remove CAccountingEntry class.Mar 3 2020, 20:16
Fabien accepted this revision.Mar 4 2020, 08:16
Fabien added a subscriber: Fabien.

Please run the wallet functional tests as part of the test plan: ./test/functional/test_runner.py wallet_*. (wallet_backup is part of the extended tests).

This revision is now accepted and ready to land.Mar 4 2020, 08:16
Fabien mentioned this in D5416: [wallet] Remove ListAccountCreditDebit().Mar 4 2020, 08:17
nakihito edited the test plan for this revision. (Show Details)Mar 4 2020, 20:38
Closed by commit rABCae17dc97a0a7: [wallet] Don't read acentry key-values from wallet on load. (authored by nakihito). · Explain WhyMar 6 2020, 00:44
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABCae17dc97a0a7: [wallet] Don't read acentry key-values from wallet on load..
nakihito added a commit: rSTAGINGae17dc97a0a7: [wallet] Don't read acentry key-values from wallet on load..Apr 7 2020, 23:15

Revision Contents
Changeset List

PathSize
src/
wallet/
25 lines

Diff 16742

View Options

src/wallet/walletdb.cpp

Loading...