Page MenuHomePhabricator
Differential D4629

fuzz: Script validation flags
ClosedPublic
Actions

Authored by Fabien on Dec 4 2019, 15:27.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGdffb41fef7a6: fuzz: Script validation flags
rABCdffb41fef7a6: fuzz: Script validation flags
Summary

Add a fuzzer test for the validation flags.

Completes backport of core PR15399 (commit fab15ff):
https://github.com/bitcoin/bitcoin/pull/15399/commits/fab15ff70e8db26942db83a9aab7ebf974e8b6b2

Depends on D4628.

Test Plan
./test/fuzz/test_runner.py -l DEBUG <path_to_your_corpus> script_flags

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR15399_part2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9821
Build 17512: Default Diff Build & Tests
Build 17511: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 4 2019, 15:27
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 4 2019, 15:27
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Dec 4 2019, 15:27

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B8402: Diff 14612.Dec 4 2019, 15:38
teamcity added a comment.Dec 4 2019, 15:38

Build Bitcoin-ABC / Diffs / Diff Testing passed.

deadalnix added inline comments.Dec 9 2019, 00:40
src/test/fuzz/CMakeLists.txt
15 ↗(On Diff #14612)

I'm fairly confident this isn't the ay it supposed to be done. I'm somewhat surprised that that works at all :)

I think you are making this more complex that it needs to be by only setting the flag on some specific files.

65 ↗(On Diff #14612)

Is that important that the target has this very specific name? Because if not, then simplify.

Fabien added inline comments.Dec 9 2019, 07:42
src/test/fuzz/CMakeLists.txt
65 ↗(On Diff #14612)

No it's not. It is only done that way for consistency with autotools and I'll be happy to clean it.
I'd better do it in another diff though, as it requires to update autotools as well (otherwise the fuzz/test_runner.py will be broken, as for now it parses the Makefile.test.include to build the list of fuzz tests).

Fabien planned changes to this revision.Dec 12 2019, 11:05
Fabien updated this revision to Diff 16942.Mar 16 2020, 15:39

Rebase to address comment.

teamcity added a comment.Mar 16 2020, 15:40

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Mar 16 2020, 15:49

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B9821: Diff 16942.Mar 16 2020, 15:49
deadalnix accepted this revision.Mar 16 2020, 18:47
This revision is now accepted and ready to land.Mar 16 2020, 18:47
Fabien added a child revision: D5484: fuzz: Link BasicTestingSetup (shared with unit tests).Mar 16 2020, 19:48
Fabien added a child revision: D5499: Make the fuzzer test runner compatible with cmake.Mar 17 2020, 15:34
Closed by commit rABCdffb41fef7a6: fuzz: Script validation flags (authored by MarcoFalke <falke.marco@gmail.com>, committed by Fabien). · Explain WhyMar 19 2020, 15:54
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCdffb41fef7a6: fuzz: Script validation flags.
Fabien added a commit: rSTAGINGdffb41fef7a6: fuzz: Script validation flags.Apr 7 2020, 23:23

Revision Contents
Changeset List

PathSize
src/
18 lines
test/
fuzz/
33 lines
79 lines

Diff 16942

View Options

src/Makefile.test.include

Loading...
View Options

src/test/fuzz/CMakeLists.txt

Loading...
View Options

src/test/fuzz/script_flags.cpp

Loading...