[avalanche] sign avaresponse
ClosedPublic
Actions

Authored by deadalnix on Mar 23 2020, 01:18.

Details

Reviewers

Fabien
jasonbcox
nakihito

Group Reviewers

Restricted Project

Commits

rSTAGING0bd04e38c10b: [avalanche] sign avaresponse
rABC0bd04e38c10b: [avalanche] sign avaresponse

Summary

While we ultimately want to use an encrypted and authenticated tunel for avalanche, such as QUIC, having a way to experiment over TCP before this is in place is useful.

TCP is not authenticated, so we need avalanche to sign all messages to do so.

Depends on D5528 and D5536

Test Plan

Updated integration tests to check the signatures.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avatcp

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 9969
Build 17788: Default Diff Build & Tests
Build 17787: arc lint + arc unit

Event Timeline

deadalnix created this revision.Mar 23 2020, 01:18

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 23 2020, 01:18

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B9927: Diff 17108.Mar 23 2020, 01:28

Couple nits, but looks good.

src/Makefile.am
290 ↗	(On Diff #17108)	Nit: sort
test/functional/test_framework/mininode.py
29 ↗	(On Diff #17108)	Please keep the previous as a comment to indicate it's not dead code but kept for the future

This revision now requires changes to proceed.Mar 23 2020, 19:53

Fabien mentioned this in D5548: Partial Merge #14726: Use RPCHelpMan for all RPCs.Mar 24 2020, 09:17

Update

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

jasonbcox requested changes to this revision.Mar 25 2020, 18:49

jasonbcox added a subscriber: jasonbcox.

jasonbcox added inline comments.

test/functional/test_framework/messages.py
841	`__slots__`
1459	`__slots__`

This revision now requires changes to proceed.Mar 25 2020, 18:49

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B9969: Diff 17169.Mar 25 2020, 18:51

nakihito requested changes to this revision.Mar 25 2020, 20:21

nakihito added a subscriber: nakihito.

nakihito added inline comments.

src/rpc/avalanche.cpp
16–18	RPCHelpMan{"getavalanchekey, "\nReturns the key used to sign avalanche messages.\n", {}}.ToString() + in light of D5548.

Address comments

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

RPC help looks good.

Harbormaster completed remote builds in B9980: Diff 17187.Mar 26 2020, 00:32

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

jasonbcox accepted this revision.Mar 26 2020, 01:06

jasonbcox added inline comments.

src/avalanche.cpp
202 ↗	(On Diff #17187)	I'm seeing the Schnorr sig size scattered throughout the code and tests. It's coming time to consolidate that into a constant, though it doesn't need to be with this patch.
src/rpc/avalanche.cpp
16–18	Nit: This message could include a note indicating that this key is subject to change. There's no guarantee that the key will be the same on successive runs.