Page MenuHomePhabricator
Differential D552

Support cashaddr in Qt input validation
ClosedPublic
Actions

Authored by dagurval on Sep 21 2017, 23:34.

Details

Reviewers
deadalnix
freetrader
Group Reviewers
Restricted Project
Commits
rSTAGING11a84a2d0ece: Support cashaddr in Qt input validation
rABC11a84a2d0ece: Support cashaddr in Qt input validation
Summary

This makes Qt address input fields accept cash addresses.

Test Plan

added unittest, manual test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
16-10-guivalidation
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1152
Build 1152: arc lint + arc unit

Event Timeline

dagurval created this revision.Sep 21 2017, 23:34
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 21 2017, 23:34
dagurval added a child revision: D583: Support parsing cashaddr from command line.Oct 4 2017, 21:50
dagurval planned changes to this revision.Nov 7 2017, 08:21
dagurval updated this revision to Diff 1796.Nov 16 2017, 12:17

rebased

dagurval retitled this revision from [cashaddr] Check for cashaddr in GUI validation to Support cashaddr in Qt input validation.Nov 16 2017, 12:21
dagurval edited the summary of this revision. (Show Details)

Currently requires full address, including prefix.

dagurval added a child revision: D706: Use GetConfig instead of GlobalConfig.Nov 16 2017, 12:43
deadalnix requested changes to this revision.Nov 16 2017, 19:04
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/qt/guiutil.cpp
153

GetConfig

This revision now requires changes to proceed.Nov 16 2017, 19:04
dagurval updated this revision to Diff 1860.Nov 27 2017, 07:38

GetConfig()

Harbormaster completed remote builds in B1190: Diff 1860.Nov 27 2017, 07:38
dagurval mentioned this in D706: Use GetConfig instead of GlobalConfig.Nov 27 2017, 07:39
freetrader accepted this revision.Nov 29 2017, 18:26
freetrader added a subscriber: freetrader.

LGTM, tested ok.

src/qt/bitcoinaddressvalidator.cpp
54 ↗(On Diff #1860)

Surprised that linter did not introduce a newline before this one.

deadalnix accepted this revision.Nov 29 2017, 21:03
deadalnix added inline comments.
src/qt/bitcoinaddressvalidator.cpp
36 ↗(On Diff #1860)

size_t

src/qt/guiutil.cpp
153 ↗(On Diff #1860)

Considering the configs give access to the params, it's kind of weird that you need both in there.

This revision is now accepted and ready to land.Nov 29 2017, 21:03
Closed by commit rABC11a84a2d0ece: Support cashaddr in Qt input validation (authored by dagurval). · Explain WhyDec 1 2017, 08:16
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 1796

View Options

src/Makefile.qttest.include

Loading...
View Options

src/cashaddr.h

Loading...
View Options

src/cashaddr.cpp

Loading...
View Options

src/qt/bitcoinaddressvalidator.h

Loading...
View Options

src/qt/bitcoinaddressvalidator.cpp

Loading...
View Options

src/qt/guiutil.cpp

Loading...
View Options

src/qt/test/bitcoinaddressvalidatortests.h

Loading...
View Options

src/qt/test/bitcoinaddressvalidatortests.cpp

Loading...
View Options

src/qt/test/test_main.cpp

Loading...