Page MenuHomePhabricator
Differential D712

Move mapBlockIndex to chain.h
ClosedPublic
Actions

Authored by deadalnix on Nov 25 2017, 01:39.

Details

Reviewers
schancel
Mengerian
Group Reviewers
Restricted Project
Commits
rSTAGING8e48f8746d8c: Move mapBlockIndex to chain.h
rABC8e48f8746d8c: Move mapBlockIndex to chain.h
Summary

And use the opportunity to cleanup checkpoints.cpp in the process.

Test Plan
make check
../qa/pull-tester/rpc-tests.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
checkpoint
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1163
Build 1163: arc lint + arc unit

Event Timeline

deadalnix created this revision.Nov 25 2017, 01:39
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 25 2017, 01:39
Harbormaster completed remote builds in B1163: Diff 1823.Nov 25 2017, 01:39
dagurval added a subscriber: dagurval.Nov 26 2017, 23:08

Did you forget to move the definition of mapBlockIndex from validation.cpp, or is this on purpose? You only moved the declaration in the header file. May also want to add a comment about it being protected by cs_main

deadalnix added a comment.Nov 27 2017, 00:47

It's on purpose, it ensure global are still initialized in the right order.

schancel accepted this revision.Nov 27 2017, 02:17
This revision is now accepted and ready to land.Nov 27 2017, 02:17
Closed by commit rABC8e48f8746d8c: Move mapBlockIndex to chain.h (authored by deadalnix). · Explain WhyNov 27 2017, 02:53
This revision was automatically updated to reflect the committed changes.
jasonbcox mentioned this in D1971: [Part 4 of 5] Add a CChainState class to clarify internal interfaces.Apr 4 2019, 18:20
jasonbcox mentioned this in D2793: Merge #11041: Add LookupBlockIndex.Apr 10 2019, 17:48

Revision Contents
Changeset List

PathSize
src/
11 lines
7 lines
10 lines

Diff 1823

View Options

src/chain.h

Loading...
View Options

src/checkpoints.cpp

Loading...
View Options

src/validation.h

Loading...