Partial backport of Core PR14987
Details
Details
- Reviewers
deadalnix - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) Restricted Project - Commits
- rSTAGING50beb5f36aea: Pass more (2/4) rpcwallet RPCs Results and Examples to RPCHelpMan
rABC50beb5f36aea: Pass more (2/4) rpcwallet RPCs Results and Examples to RPCHelpMan
On master:
ninja ./bitcoind ./bitcoin-cli help > RPCs ./getrpchelps.sh RPCs master
Then on the patched branch:
ninja ./bitcoind ./getrpchelps.sh RPCs patched ./checkrpc.sh RPCs master patched rpcwallet2.diff
Verify changes in rpcwallet2.diff.
Scripts:
rpcwallet2.diff:
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- PR14987-rpcwallet2-2
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 10516 Build 18848: Default Diff Build & Tests Build 18847: arc lint + arc unit
Event Timeline
Comment Actions
[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.
Comment Actions
Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) failed.
Snippet of first build failure:
[17:33:48]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.gettime [17:33:48]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.util_time_GetTime [17:33:48]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_IsDigit [17:33:48]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_ParseInt32 [17:33:48]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_ParseInt64 [17:33:48]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_ParseUInt32 [17:33:48]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_ParseUInt64 [17:33:48]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_ParseDouble [17:33:48]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_FormatParagraph [17:33:48]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_FormatSubVersion [17:33:48]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_ParseFixedPoint [17:33:48]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_LockDirectory [17:33:48]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_DirIsWritable [17:33:48]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_ConvertBits [17:33:48]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_ToLower [17:33:48]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_ToUpper [17:33:48]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_Capitalize [17:33:48]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_threadnames_tests.util_threadnames_test_rename_threaded [17:33:48]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] validation_block_tests.processnewblock_signals_ordering [17:33:48]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] validation_tests.block_subsidy_test [17:33:48]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] validation_tests.subsidy_limit_test [17:33:48]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] validation_tests.validation_load_external_block_file [17:33:48]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] versionbits_tests.versionbits_test [17:33:48]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] versionbits_tests.versionbits_computeblockversion [17:33:48]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] work_comparator_tests.work_comparator [17:33:48]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] server_tests.server_IsDeprecatedRPCEnabled [17:33:48]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] db_tests.getwalletenv_file [17:33:48]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] db_tests.getwalletenv_directory [17:33:48]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] db_tests.getwalletenv_g_dbenvs_multiple [17:33:48]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] db_tests.getwalletenv_g_dbenvs_free_instance [17:33:48]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] coinselector_tests.bnb_search_test [17:33:48]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] coinselector_tests.knapsack_solver_test [17:33:48]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] coinselector_tests.ApproximateBestSubset [17:33:48]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] coinselector_tests.SelectCoins_test [17:33:48]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] init_tests.walletinit_verify_walletdir_default [17:33:48]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] init_tests.walletinit_verify_walletdir_custom [17:33:48]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] init_tests.walletinit_verify_walletdir_does_not_exist [17:33:48]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] init_tests.walletinit_verify_walletdir_is_not_directory [17:33:48]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] init_tests.walletinit_verify_walletdir_is_not_relative [17:33:48]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] init_tests.walletinit_verify_walletdir_no_trailing [17:33:48]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] init_tests.walletinit_verify_walletdir_no_trailing2 [17:33:48]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] psbt_wallet_tests.psbt_updater_test [17:33:48]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] psbt_wallet_tests.parse_hd_keypath [17:33:48]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_tests.scan_for_wallet_transactions [17:33:48]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_tests.importmulti_rescan [17:33:48]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_tests.importwallet_rescan [17:33:48]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_tests.coin_mark_dirty_immature_credit [17:33:48]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_tests.ComputeTimeSmart [17:33:48]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_tests.LoadReceiveRequests [17:33:48]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_tests.ListCoins [17:33:48]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_tests.wallet_disableprivkeys [17:33:48]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] walletdb_tests.write_erase_name [17:33:48]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] walletdb_tests.write_erase_purpose [17:33:48]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] walletdb_tests.write_erase_destdata [17:33:48]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] walletdb_tests.no_dest_fails [17:33:48]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_crypto_tests.passphrase [17:33:48]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_crypto_tests.encrypt [17:33:48]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_crypto_tests.decrypt [17:33:56]W: [Step 1/2] Process exited with code 1 [17:33:56]E: [Step 1/2] Process exited with code 1 (Step: Command Line)
Each failure log is accessible here:
Bitcoin ABC functional tests: abc-cmdline.py
Bitcoin ABC functional tests: feature_blocksdir.py
Bitcoin ABC functional tests: feature_config_args.py
Bitcoin ABC functional tests: feature_includeconf.py
Bitcoin ABC functional tests: feature_logging.py
Bitcoin ABC functional tests: feature_uacomment.py
Bitcoin ABC functional tests: wallet_multiwallet.py
Bitcoin ABC functional tests: wallet_multiwallet.py --usecli