Differential D5961

[backport#15638] [build] Move CheckTransaction from lib_server to lib_consensus
ClosedPublic
Actions

Authored by majcosta on May 5 2020, 12:40.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGa482f6fb1f86: [backport#15638] [build] Move CheckTransaction from lib_server to lib_consensus
rABCa482f6fb1f86: [backport#15638] [build] Move CheckTransaction from lib_server to lib_consensus

Summary

CheckTransaction (N.f.B: CheckCoinbase, CheckTransactionCommon and CheckRegularTransaction
in our case ) is a context-free function that does not require access to the blockchain
or mempool. Move it from src/consensus/tx_verify in lib_server to a new unit
src/consensus/tx_check in lib_consensus so that it can be called by non-server libraries.

fdf8888b6f0c63e8a4cb1459752625e642d6a4dd (John Newbery)

This is a partial backport of Core PR15638

Test Plan

ninja check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.May 5 2020, 12:40

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 5 2020, 12:40

majcosta requested review of this revision.May 5 2020, 12:40

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10588: Diff 19433.May 5 2020, 12:50

Please indicate the specific commit.

This revision now requires changes to proceed.May 5 2020, 14:02

specific commit linked in summary

deadalnix accepted this revision.May 5 2020, 15:24

deadalnix added inline comments.

src/consensus/tx_check.h
17 ↗	(On Diff #19433)	Add new line.

This revision is now accepted and ready to land.May 5 2020, 15:24

Closed by commit rABCa482f6fb1f86: [backport#15638] [build] Move CheckTransaction from lib_server to lib_consensus (authored by John Newbery <john@johnnewbery.com>, committed by majcosta). · Explain WhyMay 5 2020, 15:56

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABCa482f6fb1f86: [backport#15638] [build] Move CheckTransaction from lib_server to lib_consensus.

majcosta added a commit: rSTAGINGa482f6fb1f86: [backport#15638] [build] Move CheckTransaction from lib_server to lib_consensus.May 5 2020, 19:19

majcosta mentioned this in D6789: [fix] actually move tx_check.cpp from libserver to libbitcoin consensus.Jun 30 2020, 21:20

majcosta mentioned this in rABCe3f3596aeccb: [fix] actually move tx_check.cpp from libserver to libbitcoin consensus.Jun 30 2020, 22:41

Revision Contents
Changeset List

Path

Size

src/

1 line

2 lines

consensus/

26 lines

95 lines

7 lines

84 lines

test/

sighash_tests.cpp

2 lines

transaction_tests.cpp

1 line

1 line

wallet/

2 lines

Diff 19442

src/CMakeLists.txt

Loading...

src/Makefile.am

Loading...

src/consensus/tx_check.h

Loading...

src/consensus/tx_check.cpp

Loading...

src/consensus/tx_verify.h

Loading...

src/consensus/tx_verify.cpp

Loading...

src/test/sighash_tests.cpp

Loading...

src/test/transaction_tests.cpp

Loading...

src/validation.cpp

Loading...

src/wallet/walletdb.cpp

Loading...