Page MenuHomePhabricator
Differential D6075

Merge #16918: test: Make PORT_MIN in test runner configurable
ClosedPublic
Actions

Authored by jasonbcox on May 14 2020, 19:23.

Details

Reviewers
nakihito
Group Reviewers
Restricted Project
Commits
rSTAGING573ecef355f4: Merge #16918: test: Make PORT_MIN in test runner configurable
rABC573ecef355f4: Merge #16918: test: Make PORT_MIN in test runner configurable
Summary

fa69588537bc91c0aedbc89ef1760d89cbffad75 test: Make PORT_MIN in test runner configurable (MarcoFalke)

Pull request description:

This is needed when some ports in the port range are used by other processes. Note that simply assigning the ports dynamically does not work:

* We spin up several nodes per test (each node gets its own port)
* We run several tests in parallel

So to avoid nodes from different tests colliding on ports, the port assignment must be deterministic (can not be dynamic).

Fixes: #10869

ACKs for top commit:

practicalswift:
  ACK fa69588537bc91c0aedbc89ef1760d89cbffad75 -- diff looks correct
promag:
  ACK fa69588537bc91c0aedbc89ef1760d89cbffad75.

Tree-SHA512: e79adb015e7de79064e2d14336c38bc9672bd779ad6c52917721897e73f617c39d32c068a369c26670002a6c4ab95a71ef3a6878ebdd9710e02f410e2f7bcd14

Backport of Core PR16918

Test Plan

ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jasonbcox created this revision.May 14 2020, 19:23
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 14 2020, 19:23
jasonbcox requested review of this revision.May 14 2020, 19:23
teamcity edited the summary of this revision. (Show Details)May 14 2020, 19:24

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 14 2020, 19:24

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 14 2020, 19:24

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 14 2020, 19:24

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 14 2020, 19:25

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 14 2020, 19:29

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 14 2020, 19:38

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10768: Diff 20055.May 14 2020, 19:38
nakihito accepted this revision.EditedMay 14 2020, 19:38
nakihito added a subscriber: nakihito.

diff looks correct.

This revision is now accepted and ready to land.May 14 2020, 19:38
jasonbcox added a child revision: D6076: Bump PORT_MIN in test framework to not collide with testnet.May 14 2020, 19:41
Closed by commit rABC573ecef355f4: Merge #16918: test: Make PORT_MIN in test runner configurable (authored by MarcoFalke <falke.marco@gmail.com>, committed by jasonbcox). · Explain WhyMay 14 2020, 19:51
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC573ecef355f4: Merge #16918: test: Make PORT_MIN in test runner configurable.
jasonbcox added a commit: rSTAGING573ecef355f4: Merge #16918: test: Make PORT_MIN in test runner configurable.May 14 2020, 19:55

Revision Contents
Changeset List

PathSize
test/
functional/
test_framework/
4 lines

Diff 20064

View Options

test/functional/test_framework/util.py

Loading...